Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932827AbdCGPrN (ORCPT ); Tue, 7 Mar 2017 10:47:13 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:54031 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932775AbdCGPq4 (ORCPT ); Tue, 7 Mar 2017 10:46:56 -0500 Date: Tue, 7 Mar 2017 16:46:52 +0100 From: Pavel Machek To: Jack Wang Cc: NeilBrown , Jens Axboe , LKML , Lars Ellenberg , Kent Overstreet , Mike Snitzer , Mikulas Patocka Subject: Re: [PATCH] blk: improve order of bio handling in generic_make_request() Message-ID: <20170307154652.GA8515@amd> References: <87h93blz6g.fsf@notabene.neil.brown.name> <71562c2c-97f4-9a0a-32ec-30e0702ca575@profitbricks.com> <87lgsjj9w8.fsf@notabene.neil.brown.name> <3f261bbe-dcec-db4b-947c-357a5b86a515@profitbricks.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="envbJBWh7q8WU6mo" Content-Disposition: inline In-Reply-To: <3f261bbe-dcec-db4b-947c-357a5b86a515@profitbricks.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1674 Lines: 62 --envbJBWh7q8WU6mo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon 2017-03-06 10:43:59, Jack Wang wrote: >=20 >=20 > On 06.03.2017 05:40, NeilBrown wrote: > > On Fri, Mar 03 2017, Jack Wang wrote: > >> > >> Thanks Neil for pushing the fix. > >> > >> We can optimize generic_make_request a little bit: > >> - assign bio_list struct hold directly instead init and merge > >> - remove duplicate code > >> > >> I think better to squash into your fix. > >=20 > > Hi Jack, > > I don't object to your changes, but I'd like to see a response from > > Jens first. > > My preference would be to get the original patch in, then other changes > > that build on it, such as this one, can be added. Until the core > > changes lands, any other work is pointless. > >=20 > > Of course if Jens wants a this merged before he'll apply it, I'll > > happily do that. > >=20 > > Thanks, > > NeilBrown >=20 > Hi Neil, >=20 > Totally agree, let's wait for Jens's decision. >=20 > Hi Jens, >=20 > Please consider this fix also for stable 4.3+=20 Stable? We don't put this into stable, with exception of minimal fixes for real bugs... Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --envbJBWh7q8WU6mo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAli+1ewACgkQMOfwapXb+vISvwCggIO2O0wkwmcF4F/6nCI1z8HA mccAoLFeWTMquJzhIPZwTg31cWBuuzFF =gjE/ -----END PGP SIGNATURE----- --envbJBWh7q8WU6mo--