Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755673AbdCGQDW (ORCPT ); Tue, 7 Mar 2017 11:03:22 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:43892 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754234AbdCGQDF (ORCPT ); Tue, 7 Mar 2017 11:03:05 -0500 Subject: Re: [PATCH] mm: Do not use double negation for testing page flags To: Minchan Kim , Andrew Morton References: <1488868597-32222-1-git-send-email-minchan@kernel.org> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@lge.com, Vlastimil Vlastimil Babka , Michal Hocko , "Kirill A . Shutemov" , Johannes Weiner , Chen Gang From: Anshuman Khandual Date: Tue, 7 Mar 2017 21:31:18 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1488868597-32222-1-git-send-email-minchan@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable x-cbid: 17030716-0044-0000-0000-00000233CAEC X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17030716-0045-0000-0000-000006ACBDE0 Message-Id: <8b5c4679-484e-fe7f-844b-af5fd41b01e0@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-07_11:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703070131 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 492 Lines: 12 On 03/07/2017 12:06 PM, Minchan Kim wrote: > With the discussion[1], I found it seems there are every PageFlags > functions return bool at this moment so we don't need double > negation any more. > Although it's not a problem to keep it, it makes future users > confused to use dobule negation for them, too. > > Remove such possibility. A quick search of '!!Page' in the source tree does not show any other place having this double negation. So I guess this is all which need to be fixed.