Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932989AbdCGRNw (ORCPT ); Tue, 7 Mar 2017 12:13:52 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:48511 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932891AbdCGRNH (ORCPT ); Tue, 7 Mar 2017 12:13:07 -0500 Date: Tue, 7 Mar 2017 20:12:29 +0300 From: Dan Carpenter To: Suniel Mahesh Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, suniel.spartan@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8192e: fix coding style issue, improve error handling Message-ID: <20170307171229.GE4171@mwanda> References: <1488870580-10144-1-git-send-email-sunil.m@techveda.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1488870580-10144-1-git-send-email-sunil.m@techveda.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 267 Lines: 10 On Tue, Mar 07, 2017 at 12:39:40PM +0530, Suniel Mahesh wrote: > Fix coding style issue and comments in rtl_core.c > Return -ENOMEM, if it is out of memory > Pointer comparison with NULL replaced by logical NOT > Split it up into 3 commits. regards, dan carpenter