Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932894AbdCGR2w convert rfc822-to-8bit (ORCPT ); Tue, 7 Mar 2017 12:28:52 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:35622 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754234AbdCGR2o (ORCPT ); Tue, 7 Mar 2017 12:28:44 -0500 Subject: Re: [PATCH] s390: scsi, use setup_timer instead of init_timer To: Jiri Slaby References: <20170303124600.30225-1-jslaby@suse.cz> Cc: linux-kernel@vger.kernel.org, =?UTF-8?B?THVrw6HFoSBLb3JlbsSNaWs=?= , Martin Schwidefsky , Heiko Carstens , linux-s390@vger.kernel.org From: Steffen Maier Date: Tue, 7 Mar 2017 14:06:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170303124600.30225-1-jslaby@suse.cz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17030713-0024-0000-0000-000002C45E0B X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17030713-0025-0000-0000-000022A8671A Message-Id: <3ec42259-4968-6cf6-a460-b656af541aa5@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-07_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703070110 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1731 Lines: 50 Thanks, Lukáš, Jiri, queued for next zfcp feature submission to linux-scsi as: "zfcp: use setup_timer instead of init_timer" On 03/03/2017 01:46 PM, Jiri Slaby wrote: > From: Lukáš Korenčik > > Use inicialization with setup_timer function instead of using > init_timer function and data fields. It improves readability. > > Signed-off-by: Lukáš Korenčik > Signed-off-by: Jiri Slaby > Cc: Steffen Maier > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Cc: > --- > drivers/s390/scsi/zfcp_erp.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/s390/scsi/zfcp_erp.c b/drivers/s390/scsi/zfcp_erp.c > index 7ccfce559034..14c0cbe335b3 100644 > --- a/drivers/s390/scsi/zfcp_erp.c > +++ b/drivers/s390/scsi/zfcp_erp.c > @@ -572,9 +572,8 @@ static void zfcp_erp_memwait_handler(unsigned long data) > > static void zfcp_erp_strategy_memwait(struct zfcp_erp_action *erp_action) > { > - init_timer(&erp_action->timer); > - erp_action->timer.function = zfcp_erp_memwait_handler; > - erp_action->timer.data = (unsigned long) erp_action; > + setup_timer(&erp_action->timer, zfcp_erp_memwait_handler, > + (unsigned long) erp_action); > erp_action->timer.expires = jiffies + HZ; > add_timer(&erp_action->timer); > } > -- Mit freundlichen Grüßen / Kind regards Steffen Maier Linux on z Systems Development IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz Geschaeftsfuehrung: Dirk Wittkopp Sitz der Gesellschaft: Boeblingen Registergericht: Amtsgericht Stuttgart, HRB 243294