Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755728AbdCGRbz (ORCPT ); Tue, 7 Mar 2017 12:31:55 -0500 Received: from mail-oi0-f66.google.com ([209.85.218.66]:35612 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755313AbdCGRbu (ORCPT ); Tue, 7 Mar 2017 12:31:50 -0500 MIME-Version: 1.0 In-Reply-To: <20170102182022.2047-2-gary.bisson@boundarydevices.com> References: <20170102182022.2047-1-gary.bisson@boundarydevices.com> <20170102182022.2047-2-gary.bisson@boundarydevices.com> From: Fabio Estevam Date: Tue, 7 Mar 2017 14:19:52 -0300 Message-ID: Subject: Re: [PATCH 1/2] pinctrl: imx: use generic pinctrl helpers for managing groups To: Gary Bisson Cc: Linus Walleij , Fabio Estevam , Tony Lindgren , Shawn Guo , "linux-gpio@vger.kernel.org" , linux-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 775 Lines: 24 Hi Gary, On Mon, Jan 2, 2017 at 4:20 PM, Gary Bisson wrote: > Now using group_desc structure instead of imx_pin_group. > > Also leveraging generic functions to retrieve groups count/name/pins. > > The imx_free_pingroups function can be removed since it is now handled by > the core driver during unregister. > > Finally the device tree parsing is moved after the pinctrl driver registration > since this latter initializes the radix trees. > > Signed-off-by: Gary Bisson This patch is in 4.11-rc1 now and it causes a regression on the hog group: [ 0.061005] imx6q-pinctrl 20e0000.iomuxc: unable to find group for node hoggrp The hog pins can no longer be initialized. Could you take a look, please?