Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933055AbdCGRse (ORCPT ); Tue, 7 Mar 2017 12:48:34 -0500 Received: from gum.cmpxchg.org ([85.214.110.215]:39120 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755715AbdCGRpn (ORCPT ); Tue, 7 Mar 2017 12:45:43 -0500 Date: Tue, 7 Mar 2017 12:39:34 -0500 From: Johannes Weiner To: Minchan Kim Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@lge.com, Vlastimil Vlastimil Babka , Michal Hocko , "Kirill A . Shutemov" , Chen Gang Subject: Re: [PATCH] mm: Do not use double negation for testing page flags Message-ID: <20170307173934.GA22291@cmpxchg.org> References: <1488868597-32222-1-git-send-email-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1488868597-32222-1-git-send-email-minchan@kernel.org> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1010 Lines: 25 On Tue, Mar 07, 2017 at 03:36:37PM +0900, Minchan Kim wrote: > With the discussion[1], I found it seems there are every PageFlags > functions return bool at this moment so we don't need double > negation any more. > Although it's not a problem to keep it, it makes future users > confused to use dobule negation for them, too. > > Remove such possibility. > > [1] https://marc.info/?l=linux-kernel&m=148881578820434 > > Frankly sepaking, I like every PageFlags return bool instead of int. > It will make it clear. AFAIR, Chen Gang had tried it but don't know > why it was not merged at that time. > > http://lkml.kernel.org/r/1469336184-1904-1-git-send-email-chengang@emindsoft.com.cn > > Cc: Vlastimil Vlastimil Babka > Cc: Michal Hocko > Cc: Kirill A. Shutemov > Cc: Johannes Weiner > Cc: Chen Gang > Signed-off-by: Minchan Kim Acked-by: Johannes Weiner