MIME-Version: 1.0
In-Reply-To: <20170307182855.262ezbon2pm67qfd@treble>
References: <20170222224755.GA4310@amd> <20170222225614.4z4z24uz6l2iz6qm@treble>
 <20170222231808.hmr6ulbvfnrg2at7@treble> <20170223201039.GB5177@amd>
 <20170225050439.7dplheb6nyne4nkm@treble> <20170302234514.3qcqdozibcltkdai@treble>
 <20170306163807.GA20689@amd> <20170307173821.yknj5htr7plgdwxv@treble>
 <CA+55aFw+WVjwPBPKpnKcZUkqX=mYWv7A6M44uJpmWuzGU0zpqw@mail.gmail.com>
 <CALCETrWHdra-Po0rNrHn-cV2G=AM2pWR45rRf4t2RZfQR8Lqjg@mail.gmail.com> <20170307182855.262ezbon2pm67qfd@treble>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Tue, 7 Mar 2017 10:40:14 -0800
Message-ID: <CA+55aFyjEuRLN6PMZZqi6k0rA6=AsTTZeN37eyyJM5ig-mnM4w@mail.gmail.com>
Subject: Re: v4.10: kernel stack frame pointer .. has bad value (null)
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Andy Lutomirski <luto@amacapital.net>, Pavel Machek <pavel@ucw.cz>,
        kernel list <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>, Andrew Lutomirski <luto@kernel.org>,
        Borislav Petkov <bp@alien8.de>, Brian Gerst <brgerst@gmail.com>,
        Denys Vlasenko <dvlasenk@redhat.com>, Peter Anvin <hpa@zytor.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 789
Lines: 20

On Tue, Mar 7, 2017 at 10:28 AM, Josh Poimboeuf <jpoimboe@redhat.com> wrote:
>
> Also, the gcc documentation says -maccumulate-outgoing-args is
> "generally beneficial for performance and size."

Hmm. I wonder how true that is. I'm pretty sure it generates bigger
code, although it's probably less noticeable in the kernel (as opposed
to the traditional x86 "push everything" model) due to having the
three register arguments.

And the "it's faster" is almost certainly garbage. It's true on P4 and
some older AMD cores that couldn't do push/pops quickly.

> Not to mention the fact that -maccumulate-outgoing-args seems to already
> be enabled in most cases anyway.

Yeah, that's the main argument for this patch, I think - just remove
the (unusual) special case.

                 Linus