Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933076AbdCGTBr (ORCPT <rfc822;w@1wt.eu>);
        Tue, 7 Mar 2017 14:01:47 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:44490 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932984AbdCGTBp (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 7 Mar 2017 14:01:45 -0500
Date: Tue, 7 Mar 2017 20:01:38 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: Cheah Kok Cheong <thrust73@gmail.com>
Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Staging: comedi: comedi_fops: Change
 comedi_num_legacy_minors type
Message-ID: <20170307190137.GA6373@kroah.com>
References: <cd5f3e9f6320ac0063e61f0d0457e5400091390c.1488654618.git.thrust73@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cd5f3e9f6320ac0063e61f0d0457e5400091390c.1488654618.git.thrust73@gmail.com>
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 260
Lines: 13

On Sun, Mar 05, 2017 at 03:22:32AM +0800, Cheah Kok Cheong wrote:
> Change to unsigned to allow removal of negative value check in
> init section.

Why?

> Use smaller data type since the max possible value currently is 48.

Does it matter?

thanks,

greg k-h