Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755722AbdCGUHZ (ORCPT ); Tue, 7 Mar 2017 15:07:25 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:56188 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750744AbdCGUHW (ORCPT ); Tue, 7 Mar 2017 15:07:22 -0500 Date: Tue, 7 Mar 2017 13:42:58 +0100 From: Mark Brown To: Harald Geyer Cc: Liam Girdwood , Tejun Heo , Lai Jiangshan , linux-kernel@vger.kernel.org Message-ID: <20170307124258.raimufnbnni4pf5m@sirena.org.uk> References: <1487785285-3567-1-git-send-email-harald@ccbib.org> <20170222182111.4jajk2ed52okx323@sirena.org.uk> <20170223173449.c747nrfr3oxrjrr7@sirena.org.uk> <20170227125427.3xgdukr4ok472v6c@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lpqhkeqvoj2mm5jt" Content-Disposition: inline In-Reply-To: X-Cookie: A fool and his money are soon popular. User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 109.74.48.129 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/2] workqueue: Add new function mod_fwd_delayed_work() X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1473 Lines: 43 --lpqhkeqvoj2mm5jt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Feb 27, 2017 at 08:17:10PM +0100, Harald Geyer wrote: > Mark Brown writes: > > I'd need to figure out exactly what the restrictions are and like I say > > the name of the function itself is confusing, I suspect because it > > predates SMP. > I guess you know that, but just to avoid any confusion: The bug in the > regulator code is not related to SMP at all. It's not? Oh. I had formed the impression that this was a race condition. > > Actually yes, though not immediately. Another option is to just rename > > the current function and all the callers en masse then add a new, safe > > mod_delayed_work(). > Okay by me. I'm removing the issue from my todo list and hand it over > to you and your minions ... :) Well, we need to figure out what the desired solution is! --lpqhkeqvoj2mm5jt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAli+qtEACgkQJNaLcl1U h9DruwgAhBD5NH/FMEVxWaLLsbwMQ30T7w8lVyUJrnnp0dVoZ3d87ReIP+gUYhFH 8Y7DtKoaUomE8WIUB8LGElgGcY31K2i9IBXXSIiqHdVHiW4vm7kux71CBEn1fN6P Ys0eiHrULp5+WYG6kkflsqZxf944NC9qm5ng39HIwsUDvR09GD185QpQFQFcWfmM ORtUsnSTVRwthBBAun+387+37cP/8pv8zFaILNafDahgGUZDSLK0N9a/pPtX1Y1t k+/Eczd+9Cds40Is3p+roKAZ6t3Mbno4XRwBA4oESzfd6g0bN/K+XXflmQ744zxA lrqNMX4cdy6szgRvO1crDC1QUD+agQ== =tQmQ -----END PGP SIGNATURE----- --lpqhkeqvoj2mm5jt--