Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756195AbdCGURG (ORCPT ); Tue, 7 Mar 2017 15:17:06 -0500 Received: from mail-wm0-f53.google.com ([74.125.82.53]:38681 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751935AbdCGURC (ORCPT ); Tue, 7 Mar 2017 15:17:02 -0500 MIME-Version: 1.0 In-Reply-To: References: <20170102182022.2047-1-gary.bisson@boundarydevices.com> <20170102182022.2047-2-gary.bisson@boundarydevices.com> From: Gary Bisson Date: Tue, 7 Mar 2017 18:26:12 +0100 Message-ID: Subject: Re: [PATCH 1/2] pinctrl: imx: use generic pinctrl helpers for managing groups To: Fabio Estevam Cc: Linus Walleij , Fabio Estevam , Tony Lindgren , Shawn Guo , "linux-gpio@vger.kernel.org" , linux-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1199 Lines: 39 Hi Fabio, On Tue, Mar 7, 2017 at 6:19 PM, Fabio Estevam wrote: > Hi Gary, > > On Mon, Jan 2, 2017 at 4:20 PM, Gary Bisson > wrote: >> Now using group_desc structure instead of imx_pin_group. >> >> Also leveraging generic functions to retrieve groups count/name/pins. >> >> The imx_free_pingroups function can be removed since it is now handled by >> the core driver during unregister. >> >> Finally the device tree parsing is moved after the pinctrl driver registration >> since this latter initializes the radix trees. >> >> Signed-off-by: Gary Bisson > > This patch is in 4.11-rc1 now and it causes a regression on the hog group: > > [ 0.061005] imx6q-pinctrl 20e0000.iomuxc: unable to find group for > node hoggrp > > The hog pins can no longer be initialized. > > Could you take a look, please? No it isn't because of the use of radix but instead of: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=950b0d91dc10 It has been discussed here: https://lkml.org/lkml/2017/2/28/140 Tony offered a patch in that thread which works. Tony, have you submitted it yet? Regards, Gary