Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933121AbdCGVLK (ORCPT ); Tue, 7 Mar 2017 16:11:10 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:40638 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756186AbdCGVLG (ORCPT ); Tue, 7 Mar 2017 16:11:06 -0500 Date: Tue, 7 Mar 2017 22:01:07 +0100 From: Boris Brezillon To: Alban Cc: linux-kernel@vger.kernel.org, Mark Rutland , Moritz Fischer , devicetree@vger.kernel.org, Richard Weinberger , Marek Vasut , Rob Herring , Srinivas Kandagatla , linux-mtd@lists.infradead.org, Maxime Ripard , Brian Norris , David Woodhouse , Cyrille Pitchen Subject: Re: [PATCH v2 1/2] doc: bindings: Add bindings documentation for mtd nvmem Message-ID: <20170307220107.03436537@bbrezillon> In-Reply-To: <1488875164-30440-2-git-send-email-albeu@free.fr> References: <1488875164-30440-1-git-send-email-albeu@free.fr> <1488875164-30440-2-git-send-email-albeu@free.fr> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3007 Lines: 94 On Tue, 7 Mar 2017 09:26:03 +0100 Alban wrote: > Config data for drivers, like MAC addresses, is often stored in MTD. > Add a binding that define how such data storage can be represented in > device tree. > > Signed-off-by: Alban > --- > Changelog: > v2: * Added a "Required properties" section with the nvmem-provider > property > --- > .../devicetree/bindings/nvmem/mtd-nvmem.txt | 33 ++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > create mode 100644 Documentation/devicetree/bindings/nvmem/mtd-nvmem.txt > > diff --git a/Documentation/devicetree/bindings/nvmem/mtd-nvmem.txt b/Documentation/devicetree/bindings/nvmem/mtd-nvmem.txt > new file mode 100644 > index 0000000..8ed25e6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/nvmem/mtd-nvmem.txt > @@ -0,0 +1,33 @@ > += NVMEM in MTD = > + > +Config data for drivers, like MAC addresses, is often stored in MTD. > +This binding define how such data storage can be represented in device tree. > + > +An MTD can be defined as an NVMEM provider by adding the `nvmem-provider` > +property to their node. If everyone agrees that this is actually needed, then it should definitely go in the nvmem binding doc, and we should patch all nvmem providers to define this property (even if we keep supporting nodes that are not defining it). I'm not fully convinced yet, but I might be wrong. I also think we should take the "nvmem under flash node without partitions" into account now, or at least have a clear plan on how we want to represent it. Something like that? flash { partitions { part@X { nvmem { #address-cells = <1>; #size-cells = <1>; cell@Y { }; }; }; }; nvmem { #address-cells = <1>; #size-cells = <1>; cell@X { }; }; }; Note that patching nvmem core to support the subnode case should be pretty easy (see below). --->8--- diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index 408b521ee520..507c6190505b 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -465,7 +465,7 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config) nvmem->priv = config->priv; nvmem->reg_read = config->reg_read; nvmem->reg_write = config->reg_write; - np = config->dev->of_node; + np = config->of_node ? : config->dev->of_node; nvmem->dev.of_node = np; dev_set_name(&nvmem->dev, "%s%d", config->name ? : "nvmem", config->id); diff --git a/include/linux/nvmem-provider.h b/include/linux/nvmem-provider.h index cd93416d762e..ec2f5116d62d 100644 --- a/include/linux/nvmem-provider.h +++ b/include/linux/nvmem-provider.h @@ -21,6 +21,7 @@ typedef int (*nvmem_reg_write_t)(void *priv, unsigned int offset, struct nvmem_config { struct device *dev; + struct device_node *of_node; const char *name; int id; struct module *owner;