Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756419AbdCGWIz (ORCPT ); Tue, 7 Mar 2017 17:08:55 -0500 Received: from mail-wr0-f195.google.com ([209.85.128.195]:35302 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755807AbdCGWIk (ORCPT ); Tue, 7 Mar 2017 17:08:40 -0500 From: Michal Hocko To: Cc: Vlastimil Babka , Johannes Weiner , Mel Gorman , Andrew Morton , LKML , Michal Hocko , Heiko Carstens Subject: [PATCH 1/4] s390: get rid of superfluous __GFP_REPEAT Date: Tue, 7 Mar 2017 16:48:40 +0100 Message-Id: <20170307154843.32516-2-mhocko@kernel.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170307154843.32516-1-mhocko@kernel.org> References: <20170307154843.32516-1-mhocko@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1190 Lines: 34 From: Michal Hocko __GFP_REPEAT has a rather weak semantic but since it has been introduced around 2.6.12 it has been ignored for low order allocations. page_table_alloc then uses the flag for a single page allocation. This means that this flag has never been actually useful here because it has always been used only for PAGE_ALLOC_COSTLY requests. An earlier attempt to remove the flag 10d58bf297e2 ("s390: get rid of superfluous __GFP_REPEAT") has missed this one but the situation is very same here. Cc: Heiko Carstens Signed-off-by: Michal Hocko --- arch/s390/mm/pgalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/s390/mm/pgalloc.c b/arch/s390/mm/pgalloc.c index 995f78532cc2..2776bad61094 100644 --- a/arch/s390/mm/pgalloc.c +++ b/arch/s390/mm/pgalloc.c @@ -144,7 +144,7 @@ struct page *page_table_alloc_pgste(struct mm_struct *mm) struct page *page; unsigned long *table; - page = alloc_page(GFP_KERNEL|__GFP_REPEAT); + page = alloc_page(GFP_KERNEL); if (page) { table = (unsigned long *) page_to_phys(page); clear_table(table, _PAGE_INVALID, PAGE_SIZE/2); -- 2.11.0