Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933290AbdCHAVY (ORCPT <rfc822;w@1wt.eu>);
        Tue, 7 Mar 2017 19:21:24 -0500
Received: from mail.kernel.org ([198.145.29.136]:35106 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S933271AbdCHAVT (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 7 Mar 2017 19:21:19 -0500
Date: Tue, 7 Mar 2017 16:12:44 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-X260
To: Julien Grall <julien.grall@arm.com>
cc: Stefano Stabellini <sstabellini@kernel.org>,
        xen-devel@lists.xenproject.org, jgross@suse.com,
        linux-kernel@vger.kernel.org, Stefano Stabellini <stefano@aporeto.com>,
        boris.ostrovsky@oracle.com
Subject: Re: [Xen-devel] [PATCH 1/7] xen: import new ring macros in ring.h
In-Reply-To: <1017c144-67a7-dc69-dcda-18bf90c245ab@arm.com>
Message-ID: <alpine.DEB.2.10.1703071612080.17906@sstabellini-ThinkPad-X260>
References: <alpine.DEB.2.10.1703061147250.17906@sstabellini-ThinkPad-X260> <1488830488-18506-1-git-send-email-sstabellini@kernel.org> <1017c144-67a7-dc69-dcda-18bf90c245ab@arm.com>
User-Agent: Alpine 2.10 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1144
Lines: 37

On Tue, 7 Mar 2017, Julien Grall wrote:
> Hi Stefano,
> 
> On 03/06/2017 08:01 PM, Stefano Stabellini wrote:
> > Sync the ring.h file with upstream Xen, to introduce the new ring macros.
> > They will be used by the Xen transport for 9pfs.
> > 
> > Signed-off-by: Stefano Stabellini <stefano@aporeto.com>
> > CC: konrad.wilk@oracle.com
> > CC: boris.ostrovsky@oracle.com
> > CC: jgross@suse.com
> > 
> > ---
> > NB: The new macros have not been committed to Xen yet. Do not apply this
> > patch until they do.
> > ---
> > ---
> >  include/xen/interface/io/ring.h | 131
> > ++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 131 insertions(+)
> > 
> > diff --git a/include/xen/interface/io/ring.h
> > b/include/xen/interface/io/ring.h
> > index 21f4fbd..e16aa92 100644
> > --- a/include/xen/interface/io/ring.h
> > +++ b/include/xen/interface/io/ring.h
> 
> [...]
> 
> > +#define XEN_FLEX_RING_SIZE(order)
> > \
> > +    (1UL << (order + PAGE_SHIFT - 1))
> 
> This will need to be XEN_PAGE_SHIFT in order to works with 64K kernel.

Good point! I had it right at the beginning but I lost the change in one
of the updates from xen.git.