Message-ID: <874lz47hmt.wl%kuninori.morimoto.gx@renesas.com>
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
CC: Vinod Koul <vinod.koul@intel.com>,
        Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        <dmaengine@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dmaengine: rcar-dmac: enable descriptor mode on 40bit
In-Reply-To: <1610601.S7DYfbvybr@avalon>
References: <87tw7599od.wl%kuninori.morimoto.gx@renesas.com>
        <1610601.S7DYfbvybr@avalon>
User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset="US-ASCII"
Date: Wed, 8 Mar 2017 00:13:53 +0000
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2017 00:13:53.3717 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK2PR0601MB1922
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 590
Lines: 23


Hi Laurent

Thank you for your review

> > +#ifdef CONFIG_ARCH_DMA_ADDR_T_64BIT
> > +			if (i == 0) {
> > +				high_src_addr = chunk->src_addr >> 32;
> > +				high_dst_addr = chunk->dst_addr >> 32;
> > +			}
> 
> This will be triggered for every iteration of the while loop, so if one sg 
> entry crosses a 32-bit boundary, you won't detect it.
> 
> I know it will mean one additional #ifdef, but I think you should move that 
> code out of the while loop as I previously proposed.

Grr indeed. Thank you for pointing it.
Hmm.. OK, I will add +1 #ifdef

Best regards
---
Kuninori Morimoto