Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933649AbdCHBWM (ORCPT <rfc822;w@1wt.eu>);
        Tue, 7 Mar 2017 20:22:12 -0500
Received: from mail.kernel.org ([198.145.29.136]:41650 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S933503AbdCHBWG (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 7 Mar 2017 20:22:06 -0500
Date: Tue, 7 Mar 2017 17:13:59 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@sstabellini-ThinkPad-X260
To: Stefano Stabellini <sstabellini@kernel.org>
cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
        Stefano Stabellini <stefano@aporeto.com>, jgross@suse.com,
        Eric Van Hensbergen <ericvh@gmail.com>,
        Ron Minnich <rminnich@sandia.gov>, Latchesar Ionkov <lucho@ionkov.net>,
        v9fs-developer@lists.sourceforge.net
Subject: Re: [PATCH 6/7] xen/9pfs: receive responses
In-Reply-To: <alpine.DEB.2.10.1703071658480.8160@sstabellini-ThinkPad-X260>
Message-ID: <alpine.DEB.2.10.1703071712550.8160@sstabellini-ThinkPad-X260>
References: <alpine.DEB.2.10.1703061147250.17906@sstabellini-ThinkPad-X260> <1488830488-18506-1-git-send-email-sstabellini@kernel.org> <1488830488-18506-6-git-send-email-sstabellini@kernel.org> <a132af66-cbb8-ee5e-cc5b-c82812007eca@oracle.com>
 <alpine.DEB.2.10.1703071658480.8160@sstabellini-ThinkPad-X260>
User-Agent: Alpine 2.10 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 536
Lines: 18

On Tue, 7 Mar 2017, Stefano Stabellini wrote:
> > > +
> > > +	ring = container_of(work, struct xen_9pfs_dataring, work);
> > > +	priv = ring->priv;
> > > +
> > > +	while (1) {
> > > +		cons = ring->intf->in_cons;
> > > +		prod = ring->intf->in_prod;
> > > +		rmb();
> > 
> > 
> > Is this rmb() or mb()? (Or, in fact, virt_XXX()?) You used mb() in the
> > previous patch.
>  
> I think they should all be virt_XXX, thanks.

regarding mb() vs. rmb(), give a look at the workflow at the end of
docs/misc/9pfs.markdown, under "Ring Usage".