From: Masaki Ota <masaki.ota@jp.alps.com>
To: "dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>
CC: Paul Donohue <linux-kernel@paulsd.com>,
        Nick Fletcher <nick.m.fletcher@gmail.com>,
        Joseph Salisbury <joseph.salisbury@canonical.com>,
        "ben@smart-cactus.org" <ben@smart-cactus.org>,
        "mhocko@suse.com" <mhocko@suse.com>,
        "pali.rohar@gmail.com" <pali.rohar@gmail.com>,
        "rydberg@bitmath.org" <rydberg@bitmath.org>,
        "linux@roeck-us.net" <linux@roeck-us.net>,
        "open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [REGRESSION][v4.9.y][v4.10.y] Input: ALPS - set DualPoint flag
 for 74 03 28 devices
Thread-Topic: [REGRESSION][v4.9.y][v4.10.y] Input: ALPS - set DualPoint flag
 for 74 03 28 devices
Thread-Index: AQHSldnQOEuqHud7XkuysJn/lVJLrqGGi1aAgAC6HCCAAWDtAIAAYW+QgAClRYCAAJCW4A==
Date: Wed, 8 Mar 2017 02:36:38 +0000
Message-ID: <KAWPR01MB1092E107491DFBAD78B2E1B6C72E0@KAWPR01MB1092.jpnprd01.prod.outlook.com>
References: <78be095c-a7ae-328d-dd0a-b8470dfc1318@canonical.com>
 <20170304161509.GI4609@TopQuark.net>
 <CAM67p+6UpxCNd23rkajZZL7Oyk1c658BEzLOXpABA0etE-A_tA@mail.gmail.com>
 <20170305175619.GJ4609@TopQuark.net> <20170305180841.GK4609@TopQuark.net>
 <KAWPR01MB10928839D5E4608128F925B5C72C0@KAWPR01MB1092.jpnprd01.prod.outlook.com>
 <20170307021758.GM4609@TopQuark.net>
 <KAWPR01MB1092FD2304E3F2BC7E7C6305C72F0@KAWPR01MB1092.jpnprd01.prod.outlook.com>
 <20170307175813.GC13740@dtor-ws>
In-Reply-To: <20170307175813.GC13740@dtor-ws>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="iso-2022-jp"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2017 02:36:38.8179
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 57e76998-77bd-4b82-a424-198f46eb2254
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KAWPR01MB1092
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v282asfZ017787
Content-Length: 1537
Lines: 40

Hi, Dmitry,

OK, I will do it.

Best Regards,
Masaki Ota
-----Original Message-----
From: dmitry.torokhov@gmail.com [mailto:dmitry.torokhov@gmail.com] 
Sent: Wednesday, March 08, 2017 2:58 AM
To: 太田 真喜 Masaki Ota <masaki.ota@jp.alps.com>
Cc: Paul Donohue <linux-kernel@paulsd.com>; Nick Fletcher <nick.m.fletcher@gmail.com>; Joseph Salisbury <joseph.salisbury@canonical.com>; ben@smart-cactus.org; mhocko@suse.com; pali.rohar@gmail.com; rydberg@bitmath.org; linux@roeck-us.net; open list:HID CORE LAYER <linux-input@vger.kernel.org>; LKML <linux-kernel@vger.kernel.org>; stable@vger.kernel.org
Subject: Re: [REGRESSION][v4.9.y][v4.10.y] Input: ALPS - set DualPoint flag for 74 03 28 devices

Hi Masaki,

On Tue, Mar 07, 2017 at 08:40:20AM +0000, Masaki Ota wrote:
> Hi, Paul,
> 
> I have modified the source code. 
> 
> There are three issues.
> #1. E7=73 03 28 Button pad device is not assigned "ALPS_BUTTONPAD" Flag correctly.
> #2. E7=73 03 28 devices are not assigned " ALPS_DUALPOINT" Flag correctly.
> #3. E7=73 03 28 device cursor speed is slow.
> 
> Actually, the cause is all the same.
> E7=73 03 28 device does not get correct information from OTP.
> OTP is the device information byte. I specified correct bit.
> 
> Then, I think it is also the issue.
> #4. Stick Pointer cursor speed is fast.
> 
> I will check Stick parameter.

Could you please submit this as a proper patch now that we have confirmation that it works? Also, I wonder if V8PLUS should be full protocol instead of a flag.

Thanks.

--
Dmitry