Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751323AbdCHIWK (ORCPT ); Wed, 8 Mar 2017 03:22:10 -0500 Received: from mail-it0-f51.google.com ([209.85.214.51]:36320 "EHLO mail-it0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750770AbdCHIWI (ORCPT ); Wed, 8 Mar 2017 03:22:08 -0500 MIME-Version: 1.0 In-Reply-To: <1488644620-11488-2-git-send-email-bgolaszewski@baylibre.com> References: <1488644620-11488-1-git-send-email-bgolaszewski@baylibre.com> <1488644620-11488-2-git-send-email-bgolaszewski@baylibre.com> From: Bamvor Zhang Jian Date: Wed, 8 Mar 2017 09:21:31 +0100 Message-ID: Subject: Re: [PATCH 01/12] gpio: mockup: use devm_irq_alloc_descs() To: Bartosz Golaszewski Cc: Linus Walleij , Alexandre Courbot , Grygorii Strashko , Santosh Shilimkar , Kevin Hilman , Robert Jarzmik , linux-gpio@vger.kernel.org, lkml , linux-omap@vger.kernel.org, Thomas Gleixner , Marc Zyngier Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1679 Lines: 53 On 4 March 2017 at 17:23, Bartosz Golaszewski wrote: > Use the resource managed variant of irq_alloc_descs(). This allows us > to remove gpio_mockup_remove(). > > Signed-off-by: Bartosz Golaszewski Reviewed-by: Bamvor Jian Zhang > --- > drivers/gpio/gpio-mockup.c | 16 +--------------- > 1 file changed, 1 insertion(+), 15 deletions(-) > > diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c > index 06dac72..37c2d69 100644 > --- a/drivers/gpio/gpio-mockup.c > +++ b/drivers/gpio/gpio-mockup.c > @@ -169,7 +169,7 @@ static int gpio_mockup_irqchip_setup(struct device *dev, > struct gpio_chip *gc = &chip->gc; > int irq_base, i; > > - irq_base = irq_alloc_descs(-1, 0, gc->ngpio, 0); > + irq_base = devm_irq_alloc_descs(dev, -1, 0, gc->ngpio, 0); > if (irq_base < 0) > return irq_base; > > @@ -373,25 +373,11 @@ static int gpio_mockup_probe(struct platform_device *pdev) > return 0; > } > > -static int gpio_mockup_remove(struct platform_device *pdev) > -{ > - struct gpio_mockup_chip *chips; > - int i; > - > - chips = platform_get_drvdata(pdev); > - > - for (i = 0; i < gpio_mockup_params_nr >> 1; i++) > - irq_free_descs(chips[i].gc.irq_base, chips[i].gc.ngpio); > - > - return 0; > -} > - > static struct platform_driver gpio_mockup_driver = { > .driver = { > .name = GPIO_MOCKUP_NAME, > }, > .probe = gpio_mockup_probe, > - .remove = gpio_mockup_remove, > }; > > static struct platform_device *pdev; > -- > 2.9.3 >