Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751795AbdCHJDr (ORCPT ); Wed, 8 Mar 2017 04:03:47 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:51112 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750715AbdCHJDo (ORCPT ); Wed, 8 Mar 2017 04:03:44 -0500 From: Ravi Bangoria To: mhiramat@kernel.org, acme@kernel.org Cc: peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org, Ravi Bangoria Subject: [PATCH 2/2] perf probe: Remove stale func add_perf_probe_events Date: Wed, 8 Mar 2017 12:29:08 +0530 X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170308065908.4128-1-ravi.bangoria@linux.vnet.ibm.com> References: <20170308065908.4128-1-ravi.bangoria@linux.vnet.ibm.com> X-TM-AS-MML: disable x-cbid: 17030806-0008-0000-0000-00000539E104 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17030806-0009-0000-0000-00001344600C Message-Id: <20170308065908.4128-2-ravi.bangoria@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-08_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703080058 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1117 Lines: 40 I don't see any user of this function. This function was being copied to tools/perf/builtin-probe.c by commit b02137cc6550 ("perf probe: Move print logic into cmd_probe()"). Since then it has became stale. Signed-off-by: Ravi Bangoria --- tools/perf/util/probe-event.c | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c index 4f9d6ee..9f18204 100644 --- a/tools/perf/util/probe-event.c +++ b/tools/perf/util/probe-event.c @@ -3361,24 +3361,6 @@ void cleanup_perf_probe_events(struct perf_probe_event *pevs, int npevs) } } -int add_perf_probe_events(struct perf_probe_event *pevs, int npevs) -{ - int ret; - - ret = init_probe_symbol_maps(pevs->uprobes); - if (ret < 0) - return ret; - - ret = convert_perf_probe_events(pevs, npevs); - if (ret == 0) - ret = apply_perf_probe_events(pevs, npevs); - - cleanup_perf_probe_events(pevs, npevs); - - exit_probe_symbol_maps(); - return ret; -} - int del_perf_probe_events(struct strfilter *filter) { int ret, ret2, ufd = -1, kfd = -1; -- 2.9.3