Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752089AbdCHJhJ (ORCPT ); Wed, 8 Mar 2017 04:37:09 -0500 Received: from mail.skyhub.de ([5.9.137.197]:43850 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751763AbdCHJhF (ORCPT ); Wed, 8 Mar 2017 04:37:05 -0500 Date: Wed, 8 Mar 2017 10:35:55 +0100 From: Borislav Petkov To: Baoquan He Cc: Bhupesh Sharma , Dave Young , linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, thgarnie@google.com, Kees Cook , Thomas Gleixner , mingo@redhat.com, hpa@zytor.com, x86@kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment Message-ID: <20170308093555.yrhygjxx4mu562lp@pd.tnic> References: <1488959258-4731-1-git-send-email-bhe@redhat.com> <20170308081812.GA12600@dhcp-128-65.nay.redhat.com> <20170308090955.GB6570@x1> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170308090955.GB6570@x1> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 731 Lines: 24 On Wed, Mar 08, 2017 at 05:09:55PM +0800, Baoquan He wrote: > Yes, it looks better. I can repost with this change. Thanks. No it doesn't: #define EFI_VA_START ( -4 * (_AC(1, UL) << 30)) #define EFI_VA_END (-68 * (_AC(1, UL) << 30)) That's -4G (the shift by 30) and -68G, respectively. > > #define EFI_VA_START _AC(0xfffffffeffffffff, UL) > > #define EFI_VA_END _AC(0xffffffef00000000, UL) That is something which I need to type into a calculator first. Can you guys point your attention to something which is really broken and stop wasting your time? And there's enough really broken crap left and right... -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.