Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263590AbTETGJb (ORCPT ); Tue, 20 May 2003 02:09:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263591AbTETGJb (ORCPT ); Tue, 20 May 2003 02:09:31 -0400 Received: from mx1.elte.hu ([157.181.1.137]:17298 "HELO mx1.elte.hu") by vger.kernel.org with SMTP id S263590AbTETGJa (ORCPT ); Tue, 20 May 2003 02:09:30 -0400 Date: Tue, 20 May 2003 08:19:03 +0200 (CEST) From: Ingo Molnar Reply-To: Ingo Molnar To: Rusty Russell Cc: Linus Torvalds , , Ulrich Drepper Subject: Re: [patch] futex requeueing feature, futex-requeue-2.5.69-D3 In-Reply-To: <20030520001623.715822C08B@lists.samba.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 727 Lines: 22 On Tue, 20 May 2003, Rusty Russell wrote: > 1) Overload the last futex arg (change from timeval * to void *), > don't add YA arg at the end. the right approach is the splitup of the arguments, done in the later cleanup patch. But i'd rather add yet another argument than some nasty overload of arguments ... > 2) Use __alignof__(u32) not sizeof(u32). Sure, they're the same, but > you really mean __alignof__ here. ok. Could they ever be realistically different? Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/