Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752151AbdCHJnR (ORCPT ); Wed, 8 Mar 2017 04:43:17 -0500 Received: from mail.kernel.org ([198.145.29.136]:32976 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751972AbdCHJnP (ORCPT ); Wed, 8 Mar 2017 04:43:15 -0500 Date: Wed, 8 Mar 2017 10:43:08 +0100 From: Masami Hiramatsu To: Ravi Bangoria Cc: acme@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] perf probe: Remove stale func add_perf_probe_events Message-Id: <20170308104308.343460a35e17003b731f3760@kernel.org> In-Reply-To: <20170308065908.4128-2-ravi.bangoria@linux.vnet.ibm.com> References: <20170308065908.4128-1-ravi.bangoria@linux.vnet.ibm.com> <20170308065908.4128-2-ravi.bangoria@linux.vnet.ibm.com> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1479 Lines: 54 On Wed, 8 Mar 2017 12:29:08 +0530 Ravi Bangoria wrote: > I don't see any user of this function. This function was being copied > to tools/perf/builtin-probe.c by commit b02137cc6550 ("perf probe: Move > print logic into cmd_probe()"). Since then it has became stale. Hmm, I have intended to keep it as an library API, which allows user to add event silently (e.g. adding sdt event in background). Thanks, > > Signed-off-by: Ravi Bangoria > --- > tools/perf/util/probe-event.c | 18 ------------------ > 1 file changed, 18 deletions(-) > > diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c > index 4f9d6ee..9f18204 100644 > --- a/tools/perf/util/probe-event.c > +++ b/tools/perf/util/probe-event.c > @@ -3361,24 +3361,6 @@ void cleanup_perf_probe_events(struct perf_probe_event *pevs, int npevs) > } > } > > -int add_perf_probe_events(struct perf_probe_event *pevs, int npevs) > -{ > - int ret; > - > - ret = init_probe_symbol_maps(pevs->uprobes); > - if (ret < 0) > - return ret; > - > - ret = convert_perf_probe_events(pevs, npevs); > - if (ret == 0) > - ret = apply_perf_probe_events(pevs, npevs); > - > - cleanup_perf_probe_events(pevs, npevs); > - > - exit_probe_symbol_maps(); > - return ret; > -} > - > int del_perf_probe_events(struct strfilter *filter) > { > int ret, ret2, ufd = -1, kfd = -1; > -- > 2.9.3 > -- Masami Hiramatsu