Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752218AbdCHKAH (ORCPT ); Wed, 8 Mar 2017 05:00:07 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:42150 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751962AbdCHKAF (ORCPT ); Wed, 8 Mar 2017 05:00:05 -0500 Date: Wed, 8 Mar 2017 09:23:40 +0100 From: Heiko Carstens To: Michal Hocko Cc: linux-mm@kvack.org, Vlastimil Babka , Johannes Weiner , Mel Gorman , Andrew Morton , LKML , Michal Hocko Subject: Re: [PATCH 1/4] s390: get rid of superfluous __GFP_REPEAT References: <20170307154843.32516-1-mhocko@kernel.org> <20170307154843.32516-2-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170307154843.32516-2-mhocko@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 17030808-0040-0000-0000-0000033B4AC8 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17030808-0041-0000-0000-0000246D17B5 Message-Id: <20170308082340.GB12158@osiris> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-08_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703080070 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 932 Lines: 24 On Tue, Mar 07, 2017 at 04:48:40PM +0100, Michal Hocko wrote: > From: Michal Hocko > > __GFP_REPEAT has a rather weak semantic but since it has been introduced > around 2.6.12 it has been ignored for low order allocations. > > page_table_alloc then uses the flag for a single page allocation. This > means that this flag has never been actually useful here because it has > always been used only for PAGE_ALLOC_COSTLY requests. > > An earlier attempt to remove the flag 10d58bf297e2 ("s390: get rid of > superfluous __GFP_REPEAT") has missed this one but the situation is very > same here. > > Cc: Heiko Carstens > Signed-off-by: Michal Hocko > --- > arch/s390/mm/pgalloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) FWIW: Acked-by: Heiko Carstens If you want, this can be routed via the s390 tree, whatever you prefer.