Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751456AbdCHOvP (ORCPT ); Wed, 8 Mar 2017 09:51:15 -0500 Received: from mail-wm0-f42.google.com ([74.125.82.42]:35648 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751035AbdCHOvO (ORCPT ); Wed, 8 Mar 2017 09:51:14 -0500 MIME-Version: 1.0 In-Reply-To: <20170308142256.GI4828@yuval-lap> References: <4d92b910-f0fb-1362-0392-fccd8af1d169@users.sourceforge.net> <20170308142256.GI4828@yuval-lap> From: Devesh Sharma Date: Wed, 8 Mar 2017 20:12:03 +0530 Message-ID: Subject: Re: [PATCH 10/26] IB/ocrdma: Improve another size determination in ocrdma_init_emb_mqe() To: Yuval Shaia Cc: SF Markus Elfring , linux-rdma , Devesh Sharma , Doug Ledford , Hal Rosenstock , Sean Hefty , Selvin Xavier , LKML , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1552 Lines: 39 Acked-by: Devesh Sharma On Wed, Mar 8, 2017 at 7:52 PM, Yuval Shaia wrote: > On Wed, Mar 08, 2017 at 02:02:46PM +0100, SF Markus Elfring wrote: >> From: Markus Elfring >> Date: Tue, 7 Mar 2017 20:33:29 +0100 >> >> Replace the specification of a data structure by a pointer dereference >> as the parameter for the operator "sizeof" to make the corresponding size >> determination a bit safer according to the Linux coding style convention. >> >> Signed-off-by: Markus Elfring >> --- >> drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c >> index 7d1e1caa90de..aa32bc9f323d 100644 >> --- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c >> +++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c >> @@ -352,7 +352,7 @@ static void *ocrdma_init_emb_mqe(u8 opcode, u32 cmd_len) >> { >> struct ocrdma_mqe *mqe; >> >> - mqe = kzalloc(sizeof(struct ocrdma_mqe), GFP_KERNEL); >> + mqe = kzalloc(sizeof(*mqe), GFP_KERNEL); >> if (!mqe) >> return NULL; >> mqe->hdr.spcl_sge_cnt_emb |= > > Reviewed-by: Yuval Shaia > >> -- >> 2.12.0 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html