Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752226AbdCHPN0 (ORCPT ); Wed, 8 Mar 2017 10:13:26 -0500 Received: from mail-wr0-f178.google.com ([209.85.128.178]:33218 "EHLO mail-wr0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751816AbdCHPNY (ORCPT ); Wed, 8 Mar 2017 10:13:24 -0500 MIME-Version: 1.0 In-Reply-To: <54750756-91cd-b508-109a-83b7b2375193@users.sourceforge.net> References: <54750756-91cd-b508-109a-83b7b2375193@users.sourceforge.net> From: Devesh Sharma Date: Wed, 8 Mar 2017 20:33:44 +0530 Message-ID: Subject: Re: [PATCH 16/26] IB/ocrdma: Adjust a null pointer check in ocrdma_alloc_resources() To: SF Markus Elfring Cc: linux-rdma , Devesh Sharma , Doug Ledford , Hal Rosenstock , Sean Hefty , Selvin Xavier , LKML , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1198 Lines: 34 Acked-By: Devesh Sharma On Wed, Mar 8, 2017 at 6:45 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 7 Mar 2017 22:34:33 +0100 > > The script "checkpatch.pl" pointed information out like the following. > > Comparison to NULL could be written "!dev->stag_arr". > > Thus fix the affected source code place. > > Signed-off-by: Markus Elfring > --- > drivers/infiniband/hw/ocrdma/ocrdma_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_main.c b/drivers/infiniband/hw/ocrdma/ocrdma_main.c > index 93113feeb2d5..fbf672c79d5f 100644 > --- a/drivers/infiniband/hw/ocrdma/ocrdma_main.c > +++ b/drivers/infiniband/hw/ocrdma/ocrdma_main.c > @@ -238,7 +238,7 @@ static int ocrdma_alloc_resources(struct ocrdma_dev *dev) > > dev->stag_arr = kcalloc(OCRDMA_MAX_STAG, sizeof(*dev->stag_arr), > GFP_KERNEL); > - if (dev->stag_arr == NULL) > + if (!dev->stag_arr) > goto alloc_err; > > ocrdma_alloc_pd_pool(dev); > -- > 2.12.0 >