Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752971AbdCHPYz (ORCPT ); Wed, 8 Mar 2017 10:24:55 -0500 Received: from mail-wr0-f175.google.com ([209.85.128.175]:35540 "EHLO mail-wr0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752467AbdCHPYw (ORCPT ); Wed, 8 Mar 2017 10:24:52 -0500 MIME-Version: 1.0 In-Reply-To: <53b2ab35-8b0c-5cdd-dbc9-d38c7cf9e580@users.sourceforge.net> References: <53b2ab35-8b0c-5cdd-dbc9-d38c7cf9e580@users.sourceforge.net> From: Devesh Sharma Date: Wed, 8 Mar 2017 20:45:22 +0530 Message-ID: Subject: Re: [PATCH 21/26] IB/ocrdma: Improve another size determination in ocrdma_create_srq() To: SF Markus Elfring Cc: linux-rdma , Devesh Sharma , Doug Ledford , Hal Rosenstock , Sean Hefty , Selvin Xavier , LKML , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1319 Lines: 32 Acked-By: Devesh Sharma On Wed, Mar 8, 2017 at 6:54 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 8 Mar 2017 10:10:50 +0100 > > Replace the specification of a data type by a pointer dereference > as the parameter for the operator "sizeof" to make the corresponding size > determination a bit safer according to the Linux coding style convention. > > Signed-off-by: Markus Elfring > --- > drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > index af8798fd35b1..bedc229be89d 100644 > --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > @@ -1915,7 +1915,7 @@ struct ib_srq *ocrdma_create_srq(struct ib_pd *ibpd, > if (srq->idx_bit_fields == NULL) > goto arm_err; > memset(srq->idx_bit_fields, 0xff, > - srq->bit_fields_len * sizeof(u32)); > + srq->bit_fields_len * sizeof(*srq->idx_bit_fields)); > } > > if (init_attr->attr.srq_limit) { > -- > 2.12.0 >