Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752755AbdCHPSk (ORCPT ); Wed, 8 Mar 2017 10:18:40 -0500 Received: from mail-wm0-f50.google.com ([74.125.82.50]:35055 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752466AbdCHPSg (ORCPT ); Wed, 8 Mar 2017 10:18:36 -0500 MIME-Version: 1.0 In-Reply-To: <3954cbe9-a265-bcb8-2dac-daade1a5e967@users.sourceforge.net> References: <3954cbe9-a265-bcb8-2dac-daade1a5e967@users.sourceforge.net> From: Devesh Sharma Date: Wed, 8 Mar 2017 20:47:53 +0530 Message-ID: Subject: Re: [PATCH 24/26] IB/ocrdma: One jump label less in ocrdma_alloc_ucontext_pd() To: SF Markus Elfring Cc: linux-rdma , Devesh Sharma , Doug Ledford , Hal Rosenstock , Sean Hefty , Selvin Xavier , LKML , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1812 Lines: 54 Acked-By: Devesh Sharma On Wed, Mar 8, 2017 at 7:00 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 8 Mar 2017 11:11:35 +0100 > > This issue was detected by using the Coccinelle software. > > 1. Return directly if a call of the function "_ocrdma_alloc_pd" failed. > > 2. Reduce the scope for the local variable "status" to one case > of an if statement. > > 3. Delete the jump label "err" then. > > 4. Return zero as a constant at the end. > > Signed-off-by: Markus Elfring > --- > drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > index ae0d343d1731..d3cb8e2f099f 100644 > --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > @@ -484,19 +484,17 @@ static int ocrdma_alloc_ucontext_pd(struct ocrdma_dev *dev, > struct ocrdma_ucontext *uctx, > struct ib_udata *udata) > { > - int status = 0; > - > uctx->cntxt_pd = _ocrdma_alloc_pd(dev, uctx, udata); > if (IS_ERR(uctx->cntxt_pd)) { > - status = PTR_ERR(uctx->cntxt_pd); > + int status = PTR_ERR(uctx->cntxt_pd); > + > uctx->cntxt_pd = NULL; > - goto err; > + return status; > } > > uctx->cntxt_pd->uctx = uctx; > uctx->cntxt_pd->ibpd.device = &dev->ibdev; > -err: > - return status; > + return 0; > } > > static int ocrdma_dealloc_ucontext_pd(struct ocrdma_ucontext *uctx) > -- > 2.12.0 >