Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752767AbdCHLkP (ORCPT ); Wed, 8 Mar 2017 06:40:15 -0500 Received: from foss.arm.com ([217.140.101.70]:58124 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752410AbdCHLkM (ORCPT ); Wed, 8 Mar 2017 06:40:12 -0500 Subject: Re: [Xen-devel] [PATCH 1/7] xen: import new ring macros in ring.h To: Stefano Stabellini References: <1488830488-18506-1-git-send-email-sstabellini@kernel.org> <1017c144-67a7-dc69-dcda-18bf90c245ab@arm.com> Cc: xen-devel@lists.xenproject.org, jgross@suse.com, linux-kernel@vger.kernel.org, Stefano Stabellini , boris.ostrovsky@oracle.com From: Julien Grall Message-ID: Date: Wed, 8 Mar 2017 11:14:03 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1411 Lines: 49 Hi Stefano, On 08/03/17 00:12, Stefano Stabellini wrote: > On Tue, 7 Mar 2017, Julien Grall wrote: >> Hi Stefano, >> >> On 03/06/2017 08:01 PM, Stefano Stabellini wrote: >>> Sync the ring.h file with upstream Xen, to introduce the new ring macros. >>> They will be used by the Xen transport for 9pfs. >>> >>> Signed-off-by: Stefano Stabellini >>> CC: konrad.wilk@oracle.com >>> CC: boris.ostrovsky@oracle.com >>> CC: jgross@suse.com >>> >>> --- >>> NB: The new macros have not been committed to Xen yet. Do not apply this >>> patch until they do. >>> --- >>> --- >>> include/xen/interface/io/ring.h | 131 >>> ++++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 131 insertions(+) >>> >>> diff --git a/include/xen/interface/io/ring.h >>> b/include/xen/interface/io/ring.h >>> index 21f4fbd..e16aa92 100644 >>> --- a/include/xen/interface/io/ring.h >>> +++ b/include/xen/interface/io/ring.h >> >> [...] >> >>> +#define XEN_FLEX_RING_SIZE(order) >>> \ >>> + (1UL << (order + PAGE_SHIFT - 1)) >> >> This will need to be XEN_PAGE_SHIFT in order to works with 64K kernel. > > Good point! I had it right at the beginning but I lost the change in one > of the updates from xen.git. It is probably worth to consider introducing XEN_PAGE_SIZE in the hypervisor code because we are likely to miss the change when the headers will be re-sync in the future. Cheers, -- Julien Grall