Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752830AbdCHLkS (ORCPT ); Wed, 8 Mar 2017 06:40:18 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:43798 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752655AbdCHLkM (ORCPT ); Wed, 8 Mar 2017 06:40:12 -0500 Date: Wed, 8 Mar 2017 17:09:52 +0530 From: "Naveen N. Rao" To: Masami Hiramatsu Cc: Arnaldo Carvalho de Melo , Steven Rostedt , Ingo Molnar , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Ananth N Mavinakayanahalli , Michael Ellerman Subject: Re: [PATCH v5 5/5] perf: powerpc: choose local entry point with kretprobes References: <7445b5334673ef5404ac1d12609bad4d73d2b567.1488961018.git.naveen.n.rao@linux.vnet.ibm.com> <20170308113156.05692fd7a012ca3f647ed594@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170308113156.05692fd7a012ca3f647ed594@kernel.org> User-Agent: Mutt/1.6.2 (2016-07-01) X-TM-AS-MML: disable x-cbid: 17030811-7323-0000-0000-000000D4223A X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17030811-7324-0000-0000-000002789055 Message-Id: <20170308113952.GH11046@naverao1-tp.localdomain> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-08_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703080095 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 957 Lines: 23 On 2017/03/08 11:31AM, Masami Hiramatsu wrote: > On Wed, 8 Mar 2017 13:56:10 +0530 > "Naveen N. Rao" wrote: > > > perf now uses an offset from _text/_stext for kretprobes if the kernel > > supports it, rather than the actual function name. As such, let's choose > > the LEP for powerpc ABIv2 so as to ensure the probe gets hit. Do it only > > if the kernel supports specifying offsets with kretprobes. > > Acked-by: Masami Hiramatsu > > This patch is OK. And I found that most of functions in sym-handling.c > are used only when libelf is supported. (e.g. probe-event.c itself > is not built when we have no libelf) > So, for the next cleanup, this file should not be compiled without > libelf. There are still a few functions there which work without libelf. But, I agree that the file has far too many #ifdefs between ABIv2 and libelf. I will see if I can simplify this file. Thanks, Naveen