Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753323AbdCHNUn (ORCPT ); Wed, 8 Mar 2017 08:20:43 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:45193 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753027AbdCHNUi (ORCPT ); Wed, 8 Mar 2017 08:20:38 -0500 Subject: Re: [PATCH 2/2] perf probe: Remove stale func add_perf_probe_events To: Masami Hiramatsu References: <20170308065908.4128-1-ravi.bangoria@linux.vnet.ibm.com> <20170308065908.4128-2-ravi.bangoria@linux.vnet.ibm.com> <20170308104308.343460a35e17003b731f3760@kernel.org> Cc: acme@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org, Ravi Bangoria From: Ravi Bangoria Date: Wed, 8 Mar 2017 15:28:08 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20170308104308.343460a35e17003b731f3760@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17030809-0040-0000-0000-000002CF37EC X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006744; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000206; SDB=6.00831635; UDB=6.00408040; IPR=6.00609225; BA=6.00005199; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00014556; XFM=3.00000013; UTC=2017-03-08 09:58:16 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17030809-0041-0000-0000-000006C349D6 Message-Id: <58BFD5B0.2000103@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-08_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703080081 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 573 Lines: 15 Thanks Masami for the review, On Wednesday 08 March 2017 03:13 PM, Masami Hiramatsu wrote: > On Wed, 8 Mar 2017 12:29:08 +0530 > Ravi Bangoria wrote: > >> I don't see any user of this function. This function was being copied >> to tools/perf/builtin-probe.c by commit b02137cc6550 ("perf probe: Move >> print logic into cmd_probe()"). Since then it has became stale. > Hmm, I have intended to keep it as an library API, which allows > user to add event silently (e.g. adding sdt event in background). Makes sense. Dropping it. -Ravi