Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752164AbdCHPJv (ORCPT ); Wed, 8 Mar 2017 10:09:51 -0500 Received: from mout.web.de ([212.227.15.3]:59384 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751583AbdCHPJq (ORCPT ); Wed, 8 Mar 2017 10:09:46 -0500 Subject: [PATCH 26/26] IB/ocrdma: Adjust further ten checks for null pointers To: linux-rdma@vger.kernel.org, Devesh Sharma , Doug Ledford , Hal Rosenstock , Sean Hefty , Selvin Xavier References: Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: <19973137-7453-6a50-822a-c3a075e1c18f@users.sourceforge.net> Date: Wed, 8 Mar 2017 14:34:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:p/WdwdGDU4cngQmhFhj1z07mepg9pvUk5wd+utSLKfjvHUKyy0f 98rWlbc2bkk2nNhnUIcCgwVH7OhzYjv3l6lFILo9nF6LjqUasNguA5gEfMUB6n4bIRKJqLf eRtLYMjtTCIMgD7pXmutr07pASMacRSd+ukhTBuBpfNB9hkiVU9wk3N+QPAoHtPSWnfc0I8 t5qKxTAXJItS7oK6gqLzA== X-UI-Out-Filterresults: notjunk:1;V01:K0:bjXXb9HVfp4=:dDraoixv1POieWf65c0EEn RWt7HSKoN4zFw76/yJcQN+1TSn+wwa53him7LV5Azf9q205YhGO/7tePs6EpXkuo+UmY+xETQ BIUEUW5cq8rrtZCSpIuFs3ldLk1HgTWfJQeORViORjKj5ti/WFOmGh/LEbLKY+eHJI590I1lD cIv2GU9MwheGvRWj1RoL1mIp7gvBqODymRgNhyjNvLaT6GrW0EQ2iR/839fYNCrYsE0UQ2KGV DM1Ggf5O+cTaGRngZoeBgyLWfxqAGe36osw0/b2rReYgOPmhRJyuSxAFAA/ZqTVrdmiBLgkD2 HVLM7V1xC9bXeHXJbW4+dxhqnF9vyjezMd/nc+U9C8usOUACU9dBFFjZCc/UAOfraivCfF3kn qKJBWNzfO+7MeUAMoTyXluokwJdgFjAVbfstqzxwVxEfH617x4zUfyPIaS4sb0lYiFGzBSPTP R8+1NWmCxSkDUHTqc5tt1dAy1gC/YjE35yi3GHgz57nh0uN4OxO1lbRzV+pKb3fHTFXqbiRKD gOIQX5ngyJNfmRfpat8Q9NKxsG772qz6MQ1inJ+eyE55qjTOcuFXkJ6Zj2gle+Nn60ZPqnO5h fZBmB6R3xIHXTARlJ0Prz3cloYmmoaApP5xYrmJOEarQxIPkd8MaRFt1ig679Cuy/l3byQ5/2 PkWL4y6aXufjnushY3YmymiDHCkiLIaRF1qie03cCfSXZ28uzewMZv9s7KbwsZCgfK0MZqG8n H+h8EIFajL3IbWZzsoIXftYbqOcDuu3qMY1tSkd28jX0s8raq6hin9eBu3r1xqpS4YSL5OdzY YcnY8hK Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3354 Lines: 105 From: Markus Elfring Date: Wed, 8 Mar 2017 12:50:14 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl“ pointed information out like the following. Comparison to NULL could be written !… Thus fix affected source code places. Signed-off-by: Markus Elfring --- drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c index bfd86fd08847..bd719e7f134e 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c @@ -267,7 +267,7 @@ static int ocrdma_add_mmap(struct ocrdma_ucontext *uctx, u64 phy_addr, struct ocrdma_mm *mm; mm = kzalloc(sizeof(*mm), GFP_KERNEL); - if (mm == NULL) + if (!mm) return -ENOMEM; mm->key.phy_addr = phy_addr; mm->key.len = len; @@ -1187,7 +1187,7 @@ static int ocrdma_add_qpn_map(struct ocrdma_dev *dev, struct ocrdma_qp *qp) { int status = -EINVAL; - if (qp->id < OCRDMA_MAX_QP && dev->qp_tbl[qp->id] == NULL) { + if (qp->id < OCRDMA_MAX_QP && !dev->qp_tbl[qp->id]) { dev->qp_tbl[qp->id] = qp; status = 0; } @@ -1355,11 +1355,11 @@ static int ocrdma_alloc_wr_id_tbl(struct ocrdma_qp *qp) { qp->wqe_wr_id_tbl = kcalloc(qp->sq.max_cnt, sizeof(*qp->wqe_wr_id_tbl), GFP_KERNEL); - if (qp->wqe_wr_id_tbl == NULL) + if (!qp->wqe_wr_id_tbl) return -ENOMEM; qp->rqe_wr_id_tbl = kcalloc(qp->rq.max_cnt, sizeof(*qp->rqe_wr_id_tbl), GFP_KERNEL); - if (qp->rqe_wr_id_tbl == NULL) + if (!qp->rqe_wr_id_tbl) return -ENOMEM; return 0; @@ -1419,7 +1419,7 @@ struct ib_qp *ocrdma_create_qp(struct ib_pd *ibpd, goto gen_err; } ocrdma_set_qp_init_params(qp, pd, attrs); - if (udata == NULL) + if (!udata) qp->cap_flags |= (OCRDMA_QP_MW_BIND | OCRDMA_QP_LKEY0 | OCRDMA_QP_FAST_REG); @@ -1431,7 +1431,7 @@ struct ib_qp *ocrdma_create_qp(struct ib_pd *ibpd, goto mbx_err; /* user space QP's wr_id table are managed in library */ - if (udata == NULL) { + if (!udata) { status = ocrdma_alloc_wr_id_tbl(qp); if (status) goto map_err; @@ -1892,11 +1892,11 @@ struct ib_srq *ocrdma_create_srq(struct ib_pd *ibpd, if (status) goto err; - if (udata == NULL) { + if (!udata) { srq->rqe_wr_id_tbl = kcalloc(srq->rq.max_cnt, sizeof(*srq->rqe_wr_id_tbl), GFP_KERNEL); - if (srq->rqe_wr_id_tbl == NULL) + if (!srq->rqe_wr_id_tbl) goto arm_err; srq->bit_fields_len = (srq->rq.max_cnt / 32) + @@ -1904,7 +1904,7 @@ struct ib_srq *ocrdma_create_srq(struct ib_pd *ibpd, srq->idx_bit_fields = kmalloc_array(srq->bit_fields_len, sizeof(*srq->idx_bit_fields), GFP_KERNEL); - if (srq->idx_bit_fields == NULL) + if (!srq->idx_bit_fields) goto arm_err; memset(srq->idx_bit_fields, 0xff, srq->bit_fields_len * sizeof(*srq->idx_bit_fields)); @@ -2878,7 +2878,7 @@ static int ocrdma_poll_hwcq(struct ocrdma_cq *cq, int num_entries, if (qpn == 0) goto skip_cqe; qp = dev->qp_tbl[qpn]; - BUG_ON(qp == NULL); + BUG_ON(!qp); expand = is_cqe_for_sq(cqe) ? ocrdma_poll_scqe(qp, cqe, ibwc, &polled, &stop) -- 2.12.0