Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753560AbdCHOJi (ORCPT ); Wed, 8 Mar 2017 09:09:38 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:30696 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753138AbdCHOJh (ORCPT ); Wed, 8 Mar 2017 09:09:37 -0500 Date: Wed, 8 Mar 2017 16:06:14 +0200 From: Yuval Shaia To: SF Markus Elfring Cc: linux-rdma@vger.kernel.org, Devesh Sharma , Doug Ledford , Hal Rosenstock , Sean Hefty , Selvin Xavier , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 04/26] IB/ocrdma: Delete unnecessary variable initialisations in ocrdma_mbx_get_dcbx_config() Message-ID: <20170308140613.GD4828@yuval-lap> References: <5780384b-87ef-fb39-6804-35f7eaada0c7@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5780384b-87ef-fb39-6804-35f7eaada0c7@users.sourceforge.net> User-Agent: Mutt/1.5.24 (2015-08-30) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1453 Lines: 38 On Wed, Mar 08, 2017 at 01:48:46PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 7 Mar 2017 19:25:55 +0100 > > The local variables "req" and "rsp" will be set to appropriate pointers > a bit later. Thus omit the explicit initialisations at the beginning. > > Signed-off-by: Markus Elfring > --- > drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c > index 85bebb887c5c..517a18e9351a 100644 > --- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c > +++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c > @@ -2895,9 +2895,8 @@ static int ocrdma_mbx_get_dcbx_config(struct ocrdma_dev *dev, u32 ptype, > int status; > dma_addr_t pa; > struct ocrdma_mqe cmd; > - > - struct ocrdma_get_dcbx_cfg_req *req = NULL; > - struct ocrdma_get_dcbx_cfg_rsp *rsp = NULL; > + struct ocrdma_get_dcbx_cfg_req *req; > + struct ocrdma_get_dcbx_cfg_rsp *rsp; Reviewed-by: Yuval Shaia > struct pci_dev *pdev = dev->nic_info.pdev; > struct ocrdma_mqe_sge *mqe_sge = cmd.u.nonemb_req.sge; > > -- > 2.12.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html