Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753489AbdCHOLO (ORCPT ); Wed, 8 Mar 2017 09:11:14 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:31369 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752986AbdCHOLN (ORCPT ); Wed, 8 Mar 2017 09:11:13 -0500 Date: Wed, 8 Mar 2017 16:07:17 +0200 From: Yuval Shaia To: SF Markus Elfring Cc: linux-rdma@vger.kernel.org, Devesh Sharma , Doug Ledford , Hal Rosenstock , Sean Hefty , Selvin Xavier , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 05/26] IB/ocrdma: Improve another size determination in ocrdma_mbx_query_qp() Message-ID: <20170308140716.GE4828@yuval-lap> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1412 Lines: 36 On Wed, Mar 08, 2017 at 01:50:59PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 7 Mar 2017 19:40:31 +0100 > > Replace the specification of a data structure by a pointer dereference > as the parameter for the operator "sizeof" to make the corresponding size > determination a bit safer according to the Linux coding style convention. > > Signed-off-by: Markus Elfring > --- > drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c > index 517a18e9351a..8122a1c7d2ae 100644 > --- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c > +++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c > @@ -2487,7 +2487,7 @@ int ocrdma_mbx_query_qp(struct ocrdma_dev *dev, struct ocrdma_qp *qp, > if (status) > goto mbx_err; > rsp = (struct ocrdma_query_qp_rsp *)cmd; > - memcpy(param, &rsp->params, sizeof(struct ocrdma_qp_params)); > + memcpy(param, &rsp->params, sizeof(*param)); > mbx_err: > kfree(cmd); > return status; > -- Reviewed-by: Yuval Shaia > 2.12.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html