Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752234AbdCHPeh (ORCPT ); Wed, 8 Mar 2017 10:34:37 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:22675 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751079AbdCHPed (ORCPT ); Wed, 8 Mar 2017 10:34:33 -0500 Date: Wed, 8 Mar 2017 17:26:59 +0200 From: Yuval Shaia To: SF Markus Elfring Cc: linux-rdma@vger.kernel.org, Devesh Sharma , Doug Ledford , Hal Rosenstock , Sean Hefty , Selvin Xavier , LKML , kernel-janitors@vger.kernel.org, Wolfram Sang Subject: Re: [PATCH 15/26] IB/ocrdma: Delete an error message for a failed memory allocation in ocrdma_add() Message-ID: <20170308152658.GA4904@yuval-lap> References: <20d97719-3d3a-62f6-a249-f39cf528c5e9@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20d97719-3d3a-62f6-a249-f39cf528c5e9@users.sourceforge.net> User-Agent: Mutt/1.5.24 (2015-08-30) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1486 Lines: 42 On Wed, Mar 08, 2017 at 02:13:11PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 7 Mar 2017 22:23:17 +0100 > > Omit an extra message for a memory allocation failure in this function. > > Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Suggesting to add blank line here. > Signed-off-by: Markus Elfring > --- > drivers/infiniband/hw/ocrdma/ocrdma_main.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_main.c b/drivers/infiniband/hw/ocrdma/ocrdma_main.c > index c49b4491d4e7..93113feeb2d5 100644 > --- a/drivers/infiniband/hw/ocrdma/ocrdma_main.c > +++ b/drivers/infiniband/hw/ocrdma/ocrdma_main.c > @@ -304,10 +304,9 @@ static struct ocrdma_dev *ocrdma_add(struct be_dev_info *dev_info) > struct ocrdma_dev *dev; > > dev = (struct ocrdma_dev *)ib_alloc_device(sizeof(*dev)); > - if (!dev) { > - pr_err("Unable to allocate ib device\n"); > + if (!dev) > return NULL; > - } > + Reviewed-by: Yuval Shaia > dev->mbx_cmd = kzalloc(sizeof(struct ocrdma_mqe_emb_cmd), GFP_KERNEL); > if (!dev->mbx_cmd) > goto idr_err; > -- > 2.12.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html