Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753898AbdCHQ7H (ORCPT ); Wed, 8 Mar 2017 11:59:07 -0500 Received: from mail.kernel.org ([198.145.29.136]:60926 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752590AbdCHQ7E (ORCPT ); Wed, 8 Mar 2017 11:59:04 -0500 Date: Wed, 8 Mar 2017 11:57:58 -0500 From: Steven Rostedt To: Laurent Dufour Cc: Andrew Morton , Linux Kernel Mailing List , Thomas Gleixner , Ingo Molnar Subject: Re: RFC: SysRq nice-all-RT-tasks is broken Message-ID: <20170308115758.43b38bc7@gandalf.local.home> In-Reply-To: <20170308115114.4e20fc73@gandalf.local.home> References: <20170308115114.4e20fc73@gandalf.local.home> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 485 Lines: 13 On Wed, 8 Mar 2017 11:51:14 -0500 Steven Rostedt wrote: > Hmm, that commit was added in 2.6.18, and you're right, a lot has > changed since then. Have you tried removing it and running it under > lockdep, and see if it triggers any warnings? I did a little digging, and it appears that its the rt mutex wait lock that the comment was referring to. Today that spin lock is irq safe. I believe its safe to remove the BUG_ON(). Want me to send a patch? -- Steve