Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754153AbdCHXTC (ORCPT ); Wed, 8 Mar 2017 18:19:02 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:53491 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752465AbdCHXTA (ORCPT ); Wed, 8 Mar 2017 18:19:00 -0500 Date: Wed, 8 Mar 2017 22:22:53 +0100 From: Pavel Machek To: Linus Torvalds Cc: Josh Poimboeuf , Andy Lutomirski , kernel list , Ingo Molnar , Andrew Lutomirski , Borislav Petkov , Brian Gerst , Denys Vlasenko , Peter Anvin , Peter Zijlstra , Thomas Gleixner Subject: Re: v4.10: kernel stack frame pointer .. has bad value (null) Message-ID: <20170308212253.GA29562@amd> References: <20170225050439.7dplheb6nyne4nkm@treble> <20170302234514.3qcqdozibcltkdai@treble> <20170306163807.GA20689@amd> <20170307173821.yknj5htr7plgdwxv@treble> <20170307182855.262ezbon2pm67qfd@treble> <20170308173703.2h57rsltma3smbcm@treble> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jI8keyz6grp/JLjh" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1829 Lines: 53 --jI8keyz6grp/JLjh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > - CONFIG_FUNCTION_GRAPH_TRACER sets it on x86-32 because of a gcc bug > > where the stack gets aligned before the mcount call. This issue > > should be mostly obsolete as most modern compilers now have -mfentry. > > We could make it dependent on CC_USING_FENTRY. >=20 > Yeah. At some point we might even upgrade the compiler requirements to > no longer accept the mcount model. >=20 > I think the fentry model is gcc-4.6.0 and up. Currently I guess we > support gcc-3.2+, which is fairly ridiculous considering that 4.6.0 is > from March, 2011. So it's over five years ago already. >=20 > gcc-3.2.0 is from 2002, I think. At some point you just have to say > "caring about a 15 year old compiler is ridiculous" >=20 > The main reason we have fairly aggressively supported old compilers > tends to be some odder architectures that don't have good support, so > people use various random "this works for me" versions. >=20 > We could easily make the gcc version checks much more strict on x86, > I suspect. Well, I have fast CPUs, but most of the time they just compile stuff. Especially bisect is compile-heavy. I suspect going back to gcc-3.2 would bring me bigger advantages than CPU upgrade... Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --jI8keyz6grp/JLjh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAljAdi0ACgkQMOfwapXb+vLaRACfb8vIzukbh4bdPVB+Ks3T73Fo ftEAnRH35Zoz+SHrw9bk6Utxgapw8Vfr =k+M5 -----END PGP SIGNATURE----- --jI8keyz6grp/JLjh--