Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751094AbdCID7t (ORCPT ); Wed, 8 Mar 2017 22:59:49 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:35285 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750713AbdCID7s (ORCPT ); Wed, 8 Mar 2017 22:59:48 -0500 MIME-Version: 1.0 In-Reply-To: References: <148897088333.16106.13237004440297956899.sendpatchset@little-apple> <148897094380.16106.17145886836361556040.sendpatchset@little-apple> From: Magnus Damm Date: Thu, 9 Mar 2017 12:57:15 +0900 Message-ID: Subject: Re: [PATCH v3 06/09] iommu/ipmmu-vmsa: Write IMCTR twice To: Robin Murphy Cc: joro , Laurent Pinchart , Geert Uytterhoeven , linux-kernel , Linux-Renesas , iommu@lists.linux-foundation.org, Simon Horman , Marek Szyprowski Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1229 Lines: 39 Hi Robin, On Wed, Mar 8, 2017 at 9:34 PM, Robin Murphy wrote: > On 08/03/17 11:02, Magnus Damm wrote: >> From: Magnus Damm >> >> Write IMCTR both in the root device and the leaf node. >> >> Signed-off-by: Magnus Damm >> --- >> >> Changes since V2: >> - None >> >> Changes since V1: >> - None >> >> drivers/iommu/ipmmu-vmsa.c | 17 ++++++++++++++--- >> 1 file changed, 14 insertions(+), 3 deletions(-) >> >> --- 0018/drivers/iommu/ipmmu-vmsa.c >> +++ work/drivers/iommu/ipmmu-vmsa.c 2017-03-08 18:30:36.870607110 +0900 >> @@ -286,6 +286,16 @@ static void ipmmu_ctx_write(struct ipmmu >> ipmmu_write(domain->root, domain->context_id * IM_CTX_SIZE + reg, data); >> } >> >> +static void ipmmu_ctx_write2(struct ipmmu_vmsa_domain *domain, unsigned int reg, >> + u32 data) > > That's pretty cryptic. Maybe both functions could do with less ambiguous > names - something like ipmmu_ctx_write_root() vs. ipmmu_ctx_write_all(), > perhaps? (and if there's a more specific hardware term than "all" that > describes this kind of configuration, even better). Yeah I agree. Will fix in next version! Thanks, / magnus