Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752854AbdCIHeg (ORCPT <rfc822;w@1wt.eu>);
        Thu, 9 Mar 2017 02:34:36 -0500
Received: from mailout1.samsung.com ([203.254.224.24]:54691 "EHLO
        mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752571AbdCIHed (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 9 Mar 2017 02:34:33 -0500
MIME-version: 1.0
Content-type: text/plain; charset=UTF-8
X-AuditID: b6c32a35-f79d66d000001a37-fc-58c10573dd72
Content-transfer-encoding: 8BIT
Message-id: <58C10571.9050107@samsung.com>
Date: Thu, 09 Mar 2017 16:34:09 +0900
From: Inki Dae <inki.dae@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101
        Thunderbird/31.6.0
To: David Binderman <dcb314@hotmail.com>,
        "jy0922.shim@samsung.com" <jy0922.shim@samsung.com>,
        "sw0312.kim@samsung.com" <sw0312.kim@samsung.com>,
        "kyungmin.park@samsung.com" <kyungmin.park@samsung.com>,
        "airlied@linux.ie" <airlied@linux.ie>,
        "kgene@kernel.org" <kgene@kernel.org>,
        "krzk@kernel.org" <krzk@kernel.org>,
        "javier@osg.samsung.com" <javier@osg.samsung.com>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-samsung-soc@vger.kernel.org" 
        <linux-samsung-soc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: linux-4.11-rc1/drivers/gpu/drm/exynos/exynos5433_drm_decon.c:681:
 suspicious mask ?
In-reply-to: <DB5PR08MB0967CD7B84545DE129126A619C2C0@DB5PR08MB0967.eurprd08.prod.outlook.com>
X-Brightmail-Tracker: H4sIAAAAAAAAA01Se0hTcRTud+/uQ2l126x+Gdm6IJHk2l1Tb5bRw+JCRlb/jB7Mi/vlRLfJ
        vVtkBdk7l1piodnbImNaraU9KcoKKzQtQyLaZkhi2ZOyB0W17Rr133e+832ccz4OjWvqyHg6
        3+FCkkMsZMlY1cXbU5KTZeKW2XDqM82XP7yP8V9v5fBPBt+T/Ju3jRjfH3yk4vf0DuB8R4eP
        4tu3vKF4f283wXddPUTyNR03ML6m6hU5Z7jQW9ZGCn5vKSlc+tJDCKHdrZhw4eQmoWlPgBIq
        mrxA+ORPyKZXoFk2JFqRpEOOXKc135GXwS5abplvSUk1cMncDD6N1TlEO8pgM7OykxfmF4aX
        ZXVrxUJ3mMoWZZmdNnuW5HS7kM7mlF0Z7EqOM+o5Q5reaDTqTdNXpxtTwpIcZCs/ESKKzlDr
        Wrr2kyXgOeEBMTRkTNB3vBMoeAzsDJ4jPSCW1jCXAbxb+hRXip0YbGsdwP86+gcjjkijHsBT
        ewPRhpoZBb9VBVUeQNM4MxHeeVwQoXFmCmy+do5S9EEAr/d3k4o+CXa9bKciWMUkwuq6T1Ge
        DOPK06EoHs2Y4ZWjX6LmOOYoAcseHFFFGlrGCq99qIgOi2EsMODJimgg003Bsy/8VISHzATo
        vzm0dCasPl86hLXwdWsTpeDx0PvrGaZ4dwK440AboRTbAPxd9kSlqKbDUE8QV84ZAd8NlhHK
        ADXctUOjSARYEWgcGjAX3tvqUSkX+wD86PXge0FC7X8h1f4Lqfa/kI4B3AvGoCLZnodkrojT
        y6Jddjvy9LlOux9E/zMp5TLY9zCrBTA0YIerGe1Ns4YQ18rF9hYAaZyNU199HKbUVrF4PZKc
        FsldiOQWkBLOuBKPH53rDH+7w2XhTKmcyWjiuDSjwciOVROGSrOGyRNdqAChIiT99WF0THwJ
        uL3hdcHm+jr3yMS+EnN6e8+PZXNLMhP6PieuqRj/fXJO38aVVxo2NWvT2q2zD2K9DfF3F+fE
        JVamo2b7s99L5jR4iSpd5zBsLOdbkNA9b9KyRt5WHzK8ck8tza5b3TVOmlme2ryqgL0/KnPf
        6SXSjPWBpdXbD//0BQeKJ3i0NbET77Eq2SZySbgki38AIrrbyLUDAAA=
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHIsWRmVeSWpSXmKPExsVy+t9jAd0i1oMRBt8eGlv0njvJZPH9YILF
        la/v2SzevF3DZPHi3kUWi/7Hr5ktzp/fwG5xtukNu8Wmx9dYLS7vmsNmMeP8PiaLGZNfsjnw
        eDzuOcPmsWlVJ5vH9m8PWD3udx9n8ti8pN5jS/9ddo++LasYPT5vkgvgiHKzyUhNTEktUkjN
        S85PycxLt1UKDXHTtVBSyEvMTbVVitD1DQlSUihLzCkF8owM0ICDc4B7sJK+XYJbRu/i+6wF
        a9krDl2eytbAeIe1i5GTQ0LAROLF1wuMELaYxIV769m6GLk4hASWMkp0XznKDJLgFRCU+DH5
        HksXIwcHs4C8xJFL2SBhZgF1iUnzFjFD1D9glPj98xErRL2WxOWnZ9lBbBYBVYnpiz6zgdhs
        QPbEFffZQOaICkRIdJ+oBOkVEZjPKvHg5T6wemGBJIlHfc9ZIIZuYpRY1bYWLMEpEC/xaNca
        pgmM/LOQ3DQL4aZZSG5awMi8ilEitSC5oDgpPdcwL7Vcrzgxt7g0L10vOT93EyM4Lp9J7WA8
        uMv9EKMAB6MSD6+A8IEIIdbEsuLK3EOMEhzMSiK8uy4BhXhTEiurUovy44tKc1KLDzGaAj01
        kVlKNDkfmDLySuINTcxNzI0NLMwtLU2MlMR5G2c/CxcSSE8sSc1OTS1ILYLpY+LglGpg1Kn6
        zFtdmJw4J2rV6YTzLUbf11zIOXbFKrKn3iDO50z/6zmlt27d3SF9ys79bu+EKu1SJr3+zgPp
        vcU//03ad3BFfVuT8PrMU4veP97XZmpoO7VlYpcf2+wz7TtP+RyeUvbhgq33BSs7xzu3+OLj
        gZZ0XVm028L2i/nZBy1GepnOv+Tyd51XYinOSDTUYi4qTgQA7LomYuECAAA=
X-MTR: 20000000000000000@CPGS
X-CMS-MailID: 20170309073410epcas1p3e79dbfc06112bcb0668f61f42a728293
X-Msg-Generator: CA
X-Sender-IP: 203.254.230.26
X-Local-Sender: =?UTF-8?B?64yA7J246riwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?=
        =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?=
X-Global-Sender: =?UTF-8?B?SW5raSBEYWUbVGl6ZW4gUGxhdGZvcm0gTGFiLhtTYW1zdW5n?=
        =?UTF-8?B?IEVsZWN0cm9uaWNzG1NlbmlvciBFbmdpbmVlcg==?=
X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?=
CMS-TYPE: 101P
DLP-Filter: Pass
X-CFilter-Loop: Reflected
X-HopCount: 7
X-CMS-RootMailID: 20170306100527epcas1p349cea73e30f7720a65d312808c4b2cc3
X-RootMTR: 20170306100527epcas1p349cea73e30f7720a65d312808c4b2cc3
References: <CGME20170306100527epcas1p349cea73e30f7720a65d312808c4b2cc3@epcas1p3.samsung.com>
 <DB5PR08MB0967CD7B84545DE129126A619C2C0@DB5PR08MB0967.eurprd08.prod.outlook.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 905
Lines: 36

Hello David,

Thanks for report.

2017년 03월 06일 19:05에 David Binderman 이(가) 쓴 글:
> Hello there,
> 
> linux-4.11-rc1/drivers/gpu/drm/exynos/exynos5433_drm_decon.c:681]: (warning) Result of operator '|' is always true if one operand is non-zero. Did you intend to use '&'?
> 

Right. this is known issue and below patch fixes this,
http://www.spinics.net/lists/dri-devel/msg132589.html

This patch will go to -fixes.

> Source code is
> 
>     if (ctx->out_type | I80_HW_TRG) {
> 
> Also in the same file:
> 
> [drivers/gpu/drm/exynos/exynos5433_drm_decon.c:131]: (style) Same expression on both sides of '|'.
> 
> Source code is
> 
>        writel(TRIGCON_TE_AUTO_MASK | TRIGCON_SWTRIGEN
>                | TRIGCON_TE_AUTO_MASK | TRIGCON_SWTRIGEN,

In this case, only problem is two flags are set in duplicate. This should be cleaned up. Thanks. :)

> 
> Regards
> 
> David Binderman
> 
>