Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753094AbdCIIOB (ORCPT ); Thu, 9 Mar 2017 03:14:01 -0500 Received: from lelnx193.ext.ti.com ([198.47.27.77]:34123 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752526AbdCIIOA (ORCPT ); Thu, 9 Mar 2017 03:14:00 -0500 Subject: Re: [PATCH] phy: phy-exynos-pcie: fix the wrong error return To: Jaehoon Chung , References: <20170308082242.15915-1-jh80.chung@samsung.com> CC: , , , From: Kishon Vijay Abraham I Message-ID: <58C10EBB.1030107@ti.com> Date: Thu, 9 Mar 2017 13:43:47 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20170308082242.15915-1-jh80.chung@samsung.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1103 Lines: 34 On Wednesday 08 March 2017 01:52 PM, Jaehoon Chung wrote: > When it doesn't get the blk_base's resource, it was returned > the error about phy_base, not blk_base. > This patch is for fixing the wrong error return about blk_base. > > Fixes: cf0adb8e281b ("phy: phy-exynos-pcie: Add support for Exynos PCIe PHY") > > Signed-off-by: Jaehoon Chung merged, thanks. -Kishon > --- > drivers/phy/phy-exynos-pcie.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/phy/phy-exynos-pcie.c b/drivers/phy/phy-exynos-pcie.c > index 4f60b83..60baf25 100644 > --- a/drivers/phy/phy-exynos-pcie.c > +++ b/drivers/phy/phy-exynos-pcie.c > @@ -254,8 +254,8 @@ static int exynos_pcie_phy_probe(struct platform_device *pdev) > > res = platform_get_resource(pdev, IORESOURCE_MEM, 1); > exynos_phy->blk_base = devm_ioremap_resource(dev, res); > - if (IS_ERR(exynos_phy->phy_base)) > - return PTR_ERR(exynos_phy->phy_base); > + if (IS_ERR(exynos_phy->blk_base)) > + return PTR_ERR(exynos_phy->blk_base); > > exynos_phy->drv_data = drv_data; > >