Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753856AbdCIKXK (ORCPT ); Thu, 9 Mar 2017 05:23:10 -0500 Received: from bes.se.axis.com ([195.60.68.10]:38819 "EHLO bes.se.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751355AbdCIKXF (ORCPT ); Thu, 9 Mar 2017 05:23:05 -0500 Subject: Re: [RESEND PATCH v3 3/7] PCI: dwc: artpec6: Populate cpu_addr_fixup ops To: Kishon Vijay Abraham I , Bjorn Helgaas , Joao Pinto , , , , References: <1489041545-15730-1-git-send-email-kishon@ti.com> <1489041545-15730-4-git-send-email-kishon@ti.com> CC: From: Niklas Cassel Message-ID: <6607274e-5486-c9c8-8e97-aba7591bbfc3@axis.com> Date: Thu, 9 Mar 2017 11:21:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.6.0 MIME-Version: 1.0 In-Reply-To: <1489041545-15730-4-git-send-email-kishon@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.0.5.60] X-ClientProxiedBy: XBOX04.axis.com (10.0.5.18) To XBOX02.axis.com (10.0.5.16) X-TM-AS-GCONF: 00 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2001 Lines: 60 Acked-by: Niklas Cassel On 03/09/2017 07:39 AM, Kishon Vijay Abraham I wrote: > Populate cpu_addr_fixup ops to extract the least 28 bits of the > corresponding cpu address. > > Cc: Niklas Cassel > Acked-by: Joao Pinto > Signed-off-by: Kishon Vijay Abraham I > --- > drivers/pci/dwc/pcie-artpec6.c | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/drivers/pci/dwc/pcie-artpec6.c b/drivers/pci/dwc/pcie-artpec6.c > index fcd3ef8..5b3b3af 100644 > --- a/drivers/pci/dwc/pcie-artpec6.c > +++ b/drivers/pci/dwc/pcie-artpec6.c > @@ -78,6 +78,11 @@ static void artpec6_pcie_writel(struct artpec6_pcie *artpec6_pcie, u32 offset, u > regmap_write(artpec6_pcie->regmap, offset, val); > } > > +static u64 artpec6_pcie_cpu_addr_fixup(u64 pci_addr) > +{ > + return pci_addr & ARTPEC6_CPU_TO_BUS_ADDR; > +} > + > static int artpec6_pcie_establish_link(struct artpec6_pcie *artpec6_pcie) > { > struct dw_pcie *pci = artpec6_pcie->pci; > @@ -142,11 +147,6 @@ static int artpec6_pcie_establish_link(struct artpec6_pcie *artpec6_pcie) > */ > dw_pcie_writel_dbi(pci, MISC_CONTROL_1_OFF, DBI_RO_WR_EN); > > - pp->io_base &= ARTPEC6_CPU_TO_BUS_ADDR; > - pp->mem_base &= ARTPEC6_CPU_TO_BUS_ADDR; > - pp->cfg0_base &= ARTPEC6_CPU_TO_BUS_ADDR; > - pp->cfg1_base &= ARTPEC6_CPU_TO_BUS_ADDR; > - > /* setup root complex */ > dw_pcie_setup_rc(pp); > > @@ -234,6 +234,10 @@ static int artpec6_add_pcie_port(struct artpec6_pcie *artpec6_pcie, > return 0; > } > > +static const struct dw_pcie_ops dw_pcie_ops = { > + .cpu_addr_fixup = artpec6_pcie_cpu_addr_fixup, > +}; > + > static int artpec6_pcie_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > @@ -252,6 +256,7 @@ static int artpec6_pcie_probe(struct platform_device *pdev) > return -ENOMEM; > > pci->dev = dev; > + pci->ops = &dw_pcie_ops; > > artpec6_pcie->pci = pci; >