Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932214AbdCIKon (ORCPT <rfc822;w@1wt.eu>);
        Thu, 9 Mar 2017 05:44:43 -0500
Received: from mail-io0-f180.google.com ([209.85.223.180]:33535 "EHLO
        mail-io0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932203AbdCIKoj (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 9 Mar 2017 05:44:39 -0500
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.20.1703091032020.3521@nanos>
References: <1488992645-9980-1-git-send-email-bgolaszewski@baylibre.com> <alpine.DEB.2.20.1703091032020.3521@nanos>
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Date: Thu, 9 Mar 2017 11:35:48 +0100
Message-ID: <CAMpxmJW64GFxM86bjO_iyn8eFsCJT8rd=_t_9faYLurAiAoWjA@mail.gmail.com>
Subject: Re: [PATCH v2] irq: generic-chip: provide irq_free_generic_chip()
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Marc Zyngier <marc.zyngier@arm.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1259
Lines: 39

2017-03-09 11:17 GMT+01:00 Thomas Gleixner <tglx@linutronix.de>:
> On Wed, 8 Mar 2017, Bartosz Golaszewski wrote:
>
>> Some users of irq_alloc_generic_chip() are modules which can be
>> removed (e.g. gpio-ml-ioh) but have no means of freeing the allocated
>> generic chip. Provide a function for that.
>
> They have means, i.e. kfree(gc). If you want a wrapper for that then please
> make it a simple static inline w/o the bloat of an exported symbol.
>

Yes, I want a wrapper, since there are no guarantees as to what
irq_alloc_generic_chip() does internally.

> But, what you really want is a proper counterpart to
> irq_alloc_generic_chip() which undoes everything what
> irq_alloc_generic_chip() does.
>
> You have to call irq_remove_generic_chip() before calling kfree() or the
> wrapper anyway. And looking at the 3 users of irq_remove_generic_chip():
>
> Two of them (drivers/gpio/gpio-tb10x.c drivers/mfd/jz4740-adc.c) do
>
>     irq_remove_generic_chip(gc)
>     kfree(gc)
>
> The third one (arch/arm/mach-omap2/prm_common.c) leaks the generic chip
> memory....
>
> So the proper solution is to rename irq_remove_generic_chip() to
> irq_destroy_generic_chip() and do the kfree() at the end of that function.
>
> Hmm?
>

Sounds good!

Thanks,
Bartosz