Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932221AbdCIKvL (ORCPT ); Thu, 9 Mar 2017 05:51:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55092 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932193AbdCIKvJ (ORCPT ); Thu, 9 Mar 2017 05:51:09 -0500 Subject: Re: [PATCH 2/6] KVM: VMX: cleanup check for invalid EPT violation To: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <1488996236-5676-1-git-send-email-pbonzini@redhat.com> <1488996236-5676-3-git-send-email-pbonzini@redhat.com> <5de81ced-c083-25e1-8954-6c232b9a7acd@redhat.com> Cc: bdas@redhat.com, dmatlack@google.com From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <52507881-6444-8704-7c3a-a9c87f8e0a9b@redhat.com> Date: Thu, 9 Mar 2017 11:50:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <5de81ced-c083-25e1-8954-6c232b9a7acd@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 09 Mar 2017 10:50:59 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 683 Lines: 25 Am 09.03.2017 um 11:43 schrieb David Hildenbrand: > Am 08.03.2017 um 19:03 schrieb Paolo Bonzini: >> handle_ept_violation is checking for "guest-linear-address invalid" + >> "paging-structure walk", which is a sign of a bug in KVM. However, >> _all_ EPT violations without a valid guest linear address are paging >> structure walks, because those EPT violations happen when loading the >> guest PDPTEs. So simplify the check to only look at bit 7 of the >> exit qualification. > > Do we have any define for this magic bit 7? > > #EPT_EXITQ_GLA_VALID 0x80 > Introducing #define EPT_VIOLATION_GLA_VALID_BIT #define EPT_VIOLATION_GLA_VALID would make sense. -- Thanks, David