Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932385AbdCILrD (ORCPT ); Thu, 9 Mar 2017 06:47:03 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:19943 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932282AbdCILrA (ORCPT ); Thu, 9 Mar 2017 06:47:00 -0500 Date: Thu, 9 Mar 2017 13:46:40 +0200 From: Yuval Shaia To: SF Markus Elfring Cc: linux-rdma@vger.kernel.org, Devesh Sharma , Doug Ledford , Hal Rosenstock , Sean Hefty , Selvin Xavier , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 21/26] IB/ocrdma: Improve another size determination in ocrdma_create_srq() Message-ID: <20170309114639.GE3307@yuval-lap> References: <53b2ab35-8b0c-5cdd-dbc9-d38c7cf9e580@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53b2ab35-8b0c-5cdd-dbc9-d38c7cf9e580@users.sourceforge.net> User-Agent: Mutt/1.5.24 (2015-08-30) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1420 Lines: 36 On Wed, Mar 08, 2017 at 02:24:00PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 8 Mar 2017 10:10:50 +0100 > > Replace the specification of a data type by a pointer dereference > as the parameter for the operator "sizeof" to make the corresponding size > determination a bit safer according to the Linux coding style convention. > > Signed-off-by: Markus Elfring > --- > drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > index af8798fd35b1..bedc229be89d 100644 > --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > @@ -1915,7 +1915,7 @@ struct ib_srq *ocrdma_create_srq(struct ib_pd *ibpd, > if (srq->idx_bit_fields == NULL) > goto arm_err; > memset(srq->idx_bit_fields, 0xff, > - srq->bit_fields_len * sizeof(u32)); > + srq->bit_fields_len * sizeof(*srq->idx_bit_fields)); > } Reviewed-by: Yuval Shaia > > if (init_attr->attr.srq_limit) { > -- > 2.12.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html