Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932189AbdCIL7f (ORCPT ); Thu, 9 Mar 2017 06:59:35 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:31735 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753583AbdCIL7d (ORCPT ); Thu, 9 Mar 2017 06:59:33 -0500 Date: Thu, 9 Mar 2017 13:59:13 +0200 From: Yuval Shaia To: SF Markus Elfring Cc: linux-rdma@vger.kernel.org, Devesh Sharma , Doug Ledford , Hal Rosenstock , Sean Hefty , Selvin Xavier , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 20/26] IB/ocrdma: Delete an unnecessary variable assignment in ocrdma_alloc_mr() Message-ID: <20170309115912.GI3307@yuval-lap> References: <24b6074a-f678-c367-484b-e16a0c1f9b5f@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <24b6074a-f678-c367-484b-e16a0c1f9b5f@users.sourceforge.net> User-Agent: Mutt/1.5.24 (2015-08-30) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1383 Lines: 39 On Wed, Mar 08, 2017 at 02:22:21PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 8 Mar 2017 10:00:41 +0100 > > Delete an assignment for the local variable "status" in an if branch > because the desired failure indication is already specified by a constant > error code at the end. > > Signed-off-by: Markus Elfring > --- > drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > index 05d55d361cfe..af8798fd35b1 100644 > --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > @@ -3031,10 +3031,8 @@ struct ib_mr *ocrdma_alloc_mr(struct ib_pd *ibpd, > return ERR_PTR(-ENOMEM); > > mr->pages = kcalloc(max_num_sg, sizeof(*mr->pages), GFP_KERNEL); > - if (!mr->pages) { > - status = -ENOMEM; > + if (!mr->pages) > goto pl_err; > - } > Reviewed-by: Yuval Shaia > status = ocrdma_get_pbl_info(dev, mr, max_num_sg); > if (status) > -- > 2.12.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html