Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932257AbdCIMDp (ORCPT ); Thu, 9 Mar 2017 07:03:45 -0500 Received: from aserp1050.oracle.com ([141.146.126.70]:47939 "EHLO aserp1050.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754457AbdCIMDS (ORCPT ); Thu, 9 Mar 2017 07:03:18 -0500 Date: Thu, 9 Mar 2017 14:01:39 +0200 From: Yuval Shaia To: SF Markus Elfring Cc: linux-rdma@vger.kernel.org, Devesh Sharma , Doug Ledford , Hal Rosenstock , Sean Hefty , Selvin Xavier , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 22/26] IB/ocrdma: Returning only value constants in ocrdma_resize_cq() Message-ID: <20170309120139.GJ3307@yuval-lap> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Source-IP: aserp1040.oracle.com [141.146.126.69] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1503 Lines: 45 On Wed, Mar 08, 2017 at 02:26:16PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 8 Mar 2017 10:48:24 +0100 > > Return constant integer values without storing them in the local > variable "status". > > Signed-off-by: Markus Elfring > --- > drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > index bedc229be89d..1d25512416f5 100644 > --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > @@ -1123,15 +1123,12 @@ struct ib_cq *ocrdma_create_cq(struct ib_device *ibdev, > int ocrdma_resize_cq(struct ib_cq *ibcq, int new_cnt, > struct ib_udata *udata) > { > - int status = 0; > struct ocrdma_cq *cq = get_ocrdma_cq(ibcq); > > - if (new_cnt < 1 || new_cnt > cq->max_hw_cqe) { > - status = -EINVAL; > - return status; > - } > + if (new_cnt < 1 || new_cnt > cq->max_hw_cqe) > + return -EINVAL; > ibcq->cqe = new_cnt; > - return status; > + return 0; Reviewed-by: Yuval Shaia > } > > static void ocrdma_flush_cq(struct ocrdma_cq *cq) > -- > 2.12.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html