Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754742AbdCIMiR (ORCPT ); Thu, 9 Mar 2017 07:38:17 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:49506 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750812AbdCIMiQ (ORCPT ); Thu, 9 Mar 2017 07:38:16 -0500 Date: Thu, 9 Mar 2017 13:38:05 +0100 From: Greg KH To: zhangshuxiaomi@gmail.com Cc: arve@android.com, riandrews@android.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, zhangshuxiao Subject: Re: [PATCH] staging: android: ashmem: lseek failed due to no FMODE_LSEEK. Message-ID: <20170309123805.GB15114@kroah.com> References: <1488968312-17282-1-git-send-email-zhangshuxiaomi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1488968312-17282-1-git-send-email-zhangshuxiaomi@gmail.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 550 Lines: 19 On Wed, Mar 08, 2017 at 06:18:32PM +0800, zhangshuxiaomi@gmail.com wrote: > From: zhangshuxiao > > vfs_llseek will check whether the file mode has > FMODE_LSEEK, no return failure. But ashmem can be > lseek, so add FMODE_LSEEK to ashmem file. Really? What is causing this failure? I haven't heard from anyone else about this issue, is there something different in your userspace framework? > > Signed-off-by: zhangshuxiao I need a "full" name for a signed-off-by: please. thanks, greg k-h