Date: Thu, 9 Mar 2017 15:49:22 +0100 (CET)
From: Miroslav Benes <mbenes@suse.cz>
To: Richard Guy Briggs <rgb@redhat.com>
cc: linux-kernel@vger.kernel.org, linux-audit@redhat.com,
        Jessica Yu <jeyu@redhat.com>, Eric Paris <eparis@redhat.com>,
        Paul Moore <pmoore@redhat.com>, Steve Grubb <sgrubb@redhat.com>
Subject: Re: [PATCH] audit: log module name on delete_module
In-Reply-To: <a6c97cf45849b9d132b1ed0b7415b04968302325.1489068452.git.rgb@redhat.com>
Message-ID: <alpine.LSU.2.20.1703091545020.24778@pobox.suse.cz>
References: <a6c97cf45849b9d132b1ed0b7415b04968302325.1489068452.git.rgb@redhat.com>
User-Agent: Alpine 2.20 (LSU 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 914
Lines: 35

On Thu, 9 Mar 2017, Richard Guy Briggs wrote:

> Record the module name of a delete_module call.
> 
> See: https://github.com/linux-audit/audit-kernel/issues/37
> 
> Signed-off-by: Richard Guy Briggs <rgb@redhat.com>

Could you improve the changelog, please? I don't think that a link to 
a github issue can and should replace it. Proper description and reason of 
the change should be in git log.

Thanks,
Miroslav

> ---
>  kernel/module.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/kernel/module.c b/kernel/module.c
> index 5432dbe..633f6da 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -943,6 +943,8 @@ SYSCALL_DEFINE2(delete_module, const char __user *, name_user,
>  		return -EFAULT;
>  	name[MODULE_NAME_LEN-1] = '\0';
>  
> +	audit_log_kern_module(name);
> +
>  	if (mutex_lock_interruptible(&module_mutex) != 0)
>  		return -EINTR;
>  
> -- 
> 1.7.1
>