Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932811AbdCIPQq (ORCPT ); Thu, 9 Mar 2017 10:16:46 -0500 Received: from mail-wr0-f193.google.com ([209.85.128.193]:32809 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932262AbdCIPQm (ORCPT ); Thu, 9 Mar 2017 10:16:42 -0500 Subject: Re: [PATCH RFC 4/4] VMX: Expose the LA57 feature to VM To: Liang Li , kvm@vger.kernel.org References: <1483003563-25847-1-git-send-email-liang.z.li@intel.com> <1483003563-25847-5-git-send-email-liang.z.li@intel.com> Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, kirill.shutemov@linux.intel.com, dave.hansen@linux.intel.com, guangrong.xiao@linux.intel.com, rkrcmar@redhat.com From: Paolo Bonzini Message-ID: Date: Thu, 9 Mar 2017 16:16:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1483003563-25847-5-git-send-email-liang.z.li@intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 550 Lines: 22 On 29/12/2016 10:26, Liang Li wrote: > - if (is_noncanonical_address(la)) > + if (is_noncanonical_address(la, virt_addr_bits(ctxt))) Using virt_addr_bits and get_virt_addr_bits is quite a mouthful. What about using instead a pair of functions like these: bool is_noncanonical_address(struct kvm_vcpu *vcpu, u64 addr) { return addr == get_canonical(addr, get_virt_addr_bits(vcpu)); } bool emulate_is_noncanonical_address(struct x86_emulate_ctxt *ctxt, u64 addr) { return addr == get_canonical(addr, virt_addr_bits(ctxt)); } Paolo