Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932739AbdCIRfu (ORCPT ); Thu, 9 Mar 2017 12:35:50 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:33121 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932093AbdCIRfs (ORCPT ); Thu, 9 Mar 2017 12:35:48 -0500 From: Taeung Song To: Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, Jiri Olsa , Namhyung Kim , Ingo Molnar , Peter Zijlstra , Wang Nan , Masami Hiramatsu , Taeung Song Subject: [PATCH v3 0/7] perf annotate: Fixes & Introduce --source-only and new source code view Date: Fri, 10 Mar 2017 02:35:34 +0900 Message-Id: <1489080941-3965-1-git-send-email-treeze.taeung@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2206 Lines: 60 Hi, Currently perf-annotate have several problems, limitaions and needs regaring line numbers and source code view. - Wrong line numbers on perf-annotate (both stdio and TUI) - Wrong sum of overhead(percent) matching source lines - Limitaions because of a dependence of 'objdump -S' - A need of source code only view with overhead for new view point for performance So I'll handle them by this patchset. First of all, fix several bugs regarding perf-annotate. And Introduce --source-only option that show source code with overhead and the new source code view for TUI. I think --source-only and the new source code view can provide a new view point for performance on source code level (and I think the view is a precheck before asm level and more readble than asm+src mixed view.) I'd appreciate it, if you give some feedback to me. Thanks, Taeung v3: - fix mistakes about a leak or missing handing exception of v2 (Namhyung) - fix several bugs about perf-annotate - keep "mixed" annotation and add new --source-only option - remove hide_src_code config for TUI v2: - contains the new source code view (Namhyung) P.S. I'm making patches for 'fold/unfold parts of asm per a line' on the new source code view. If you agree the new source code view, I keep going to do! Taeung Song (7): perf annotate: Use build-id dir when reading link name perf annotate: Avoid division by zero when calculating percent perf annotate: Fix missing setting nr samples on source_line perf annotate: More exactly grep -v in symbol__disassemble() perf annotate: Get correct line numbers matched with addr perf annotate: Introduce --source-only option perf annotate: Support the new source code view for TUI tools/perf/Documentation/perfconfig.example | 1 - tools/perf/builtin-annotate.c | 2 + tools/perf/ui/browsers/annotate.c | 238 ++++++++++++++------ tools/perf/util/annotate.c | 328 +++++++++++++++++++++++++++- tools/perf/util/annotate.h | 31 ++- tools/perf/util/symbol.c | 1 + tools/perf/util/symbol.h | 1 + 7 files changed, 518 insertions(+), 84 deletions(-) -- 2.7.4