Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932946AbdCISIn (ORCPT ); Thu, 9 Mar 2017 13:08:43 -0500 Received: from mail-qk0-f171.google.com ([209.85.220.171]:35343 "EHLO mail-qk0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932898AbdCISIl (ORCPT ); Thu, 9 Mar 2017 13:08:41 -0500 Subject: Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging To: Benjamin Gaignard , Mark Brown , Michal Hocko , Sumit Semwal , Riley Andrews , =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , Rom Lemarchand , devel@driverdev.osuosl.org, Linux Kernel Mailing List , "linaro-mm-sig@lists.linaro.org" , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, "linux-media@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Brian Starkey , Daniel Vetter , linux-mm@kvack.org References: <1488491084-17252-1-git-send-email-labbott@redhat.com> <20170303132949.GC31582@dhcp22.suse.cz> <20170306074258.GA27953@dhcp22.suse.cz> <20170306104041.zghsicrnadoap7lp@phenom.ffwll.local> <20170306105805.jsq44kfxhsvazkm6@sirena.org.uk> <20170306160437.sf7bksorlnw7u372@phenom.ffwll.local> From: Laura Abbott Message-ID: <26bc57ae-d88f-4ea0-d666-2c1a02bf866f@redhat.com> Date: Thu, 9 Mar 2017 09:38:49 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2202 Lines: 57 On 03/09/2017 02:00 AM, Benjamin Gaignard wrote: > 2017-03-06 17:04 GMT+01:00 Daniel Vetter : >> On Mon, Mar 06, 2017 at 11:58:05AM +0100, Mark Brown wrote: >>> On Mon, Mar 06, 2017 at 11:40:41AM +0100, Daniel Vetter wrote: >>> >>>> No one gave a thing about android in upstream, so Greg KH just dumped it >>>> all into staging/android/. We've discussed ION a bunch of times, recorded >>>> anything we'd like to fix in staging/android/TODO, and Laura's patch >>>> series here addresses a big chunk of that. >>> >>>> This is pretty much the same approach we (gpu folks) used to de-stage the >>>> syncpt stuff. >>> >>> Well, there's also the fact that quite a few people have issues with the >>> design (like Laurent). It seems like a lot of them have either got more >>> comfortable with it over time, or at least not managed to come up with >>> any better ideas in the meantime. >> >> See the TODO, it has everything a really big group (look at the patch for >> the full Cc: list) figured needs to be improved at LPC 2015. We don't just >> merge stuff because merging stuff is fun :-) >> >> Laurent was even in that group ... >> -Daniel > > For me those patches are going in the right direction. > > I still have few questions: > - since alignment management has been remove from ion-core, should it > be also removed from ioctl structure ? Yes, I think I'm going to go with the suggestion to fixup the ABI so we don't need the compat layer and as part of that I'm also dropping the align argument. > - can you we ride off ion_handle (at least in userland) and only > export a dma-buf descriptor ? Yes, I think this is the right direction given we're breaking everything anyway. I was debating trying to keep the two but moving to only dma bufs is probably cleaner. The only reason I could see for keeping the handles is running out of file descriptors for dma-bufs but that seems unlikely. > > In the future how can we add new heaps ? > Some platforms have very specific memory allocation > requirements (just have a look in the number of gem custom allocator in drm) > Do you plan to add heap type/mask for each ? Yes, that was my thinking. > > Benjamin > Thanks, Laura