Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754305AbdCJAGx (ORCPT ); Thu, 9 Mar 2017 19:06:53 -0500 Received: from mga01.intel.com ([192.55.52.88]:58472 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750781AbdCJAGv (ORCPT ); Thu, 9 Mar 2017 19:06:51 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,137,1486454400"; d="scan'208";a="74375345" Date: Thu, 9 Mar 2017 17:06:48 -0700 From: Ross Zwisler To: Jeff Layton Cc: viro@zeniv.linux.org.uk, akpm@linux-foundation.org, konishi.ryusuke@lab.ntt.co.jp, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-nilfs@vger.kernel.org, ross.zwisler@linux.intel.com, jack@suse.cz, neilb@suse.com, openosd@gmail.com, adilger@dilger.ca, James.Bottomley@HansenPartnership.com Subject: Re: [PATCH v2 1/9] mm: fix mapping_set_error call in me_pagecache_dirty Message-ID: <20170310000648.GA30285@linux.intel.com> Mail-Followup-To: Ross Zwisler , Jeff Layton , viro@zeniv.linux.org.uk, akpm@linux-foundation.org, konishi.ryusuke@lab.ntt.co.jp, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-nilfs@vger.kernel.org, jack@suse.cz, neilb@suse.com, openosd@gmail.com, adilger@dilger.ca, James.Bottomley@HansenPartnership.com References: <20170308162934.21989-1-jlayton@redhat.com> <20170308162934.21989-2-jlayton@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170308162934.21989-2-jlayton@redhat.com> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 314 Lines: 7 On Wed, Mar 08, 2017 at 11:29:26AM -0500, Jeff Layton wrote: > The error code should be negative. Since this ends up in the default > case anyway, this is harmless, but it's less confusing to negate it. > > Signed-off-by: Jeff Layton Reviewed-by: Ross Zwisler